Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify character related definitions. #263, #262, #259. #522

Merged
merged 1 commit into from
Sep 21, 2018

Conversation

Tavmjong
Copy link
Contributor

Attempt to address I18N comments in #263, #262, and #259.

@dirkschulze
Copy link
Contributor

@r12a could you take a look at this PR as well to verify that the issues got fixed?

Copy link
Contributor

@AmeliaBR AmeliaBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said on the last call, I think it's okay to merge this with the understanding that additional changes still need to be made.

In particular, the definition of "addressable character" and use of the term will need to be completely revamped based on #537, where it was agreed to match implementations and use different string-indexing methods for layout attributes versus for DOM methods. So we can't have a single term that defines them both.

But the specific edits here are still useful clarifications, separate from the normative changes.

I'm also OK with no changes appendix entry for these edits, since they are editorial clarifications not normative changes. But when you do add the normative bits to this PR, then you could maybe mention "and clarified some text-related definitions".

Anyway: I'll leave it up to you to merge or add further edits, @Tavmjong.

@Tavmjong
Copy link
Contributor Author

I'm going to go ahead and merge this... and then work on #537.

@Tavmjong Tavmjong merged commit 75df76d into w3c:master Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants