This repository has been archived by the owner on Sep 19, 2018. It is now read-only.
Allow assert_throws to check that it throws without testing more #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is pulled into mercurial. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
12:48 < odinho> jgraham, Ms2ger, AryehGregor, other testharness.js people: I kinda want a way to say "WTF don't care" about the exception being thrown in assert_throws().
12:49 < Ms2ger> Why? :)
12:49 < odinho> I have the CORS-tests, and what the XHR throws is really not that important.
12:49 < odinho> In fact, it hasn't anything to do with CORS.
12:49 < odinho> And Mozilla is failing HARD, along with Webkit because of that.
12:49 < odinho> Masking other, possibly real bugs.
12:56 < Ms2ger> odinho, I'd prefer (null, fn), because really I'd rather people don't do it :)
12:56 < odinho> Ms2ger: Okay, fair enough.
12:57 < odinho> Ms2ger: Like, you have to, know what you're doing/really want it, if you do it.
12:57 < Ms2ger> Right