This repository has been archived by the owner on Sep 19, 2018. It is now read-only.
Issue #157: DOM hierarchy error with XHTML and SVG #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Critic review: https://critic.hoppipolla.co.uk/r/5939 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Ping? This change sounded uncontroversial in the discussion for Issue #157. |
| @@ -389,13 +389,20 @@ function dump_test_results(tests, status) { | |||
| var test_results = tests.map(function(x) { | |||
| return {name:x.name, status:x.status, message:x.message, stack:x.stack} | |||
| }); | |||
| data = {test:window.location.href, | |||
| var data = {test:window.location.href, | |||
| tests:test_results, | |||
There was a problem hiding this comment.
Please reindent the rest of the object.
Also, I would appreciate it if you rebased your PR, redistributing the changes into two commits: one to fix the global variables/whitespace, and one for the actual changes to fix #157.
(VS Code did not understand the comma delimited list.)
|
Thanks! |
Ms2ger
added a commit
that referenced
this pull request
Dec 30, 2015
…y-error Issue #157: DOM hierarchy error with XHTML and SVG; r=Ms2ger
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dump_test_results() would throw a DOM hierarchy error for xhtml/svg documents if the '.lastChild' happened to be one that can not accept the 'results_element'.
A couple of additional opportunistic tweaks: