ToC position bug when js is disabled

[deniak]

@bert-github noticed a small bug with the ToC position when javascript is disabled and body doesn't have the class toc-sidebar (eg. https://www.w3.org/TR/2016/WD-webmention-20160329/).
On small screens, the ToC overlaps the content instead of switching to the inline mode.
That MR should fix that bug.

[fantasai]

I'm a bit confused. If JS is disabled, .toc-sidebar will never be applied. Therefore the rule you're deleting will never be applied. So why is there a problem? Is JavaScript turned off after the page load?

[deniak]

Some documents such as webmention have the class toc-sidebar applied directly in the markup. I suppose respec is adding it while generating the snapshot. So even if you have javascript disabled, the class is there.

[marcoscaceres]

@deniak, I don't think it's ReSpec adding it... at least, I can't find that when I git grep "toc-sidebar".

[marcoscaceres]

Looking at the editor's draft, it seems that the author of that document included it explicitly (class="h-entry toc-sidebar").

[deniak]

Ah good to know. Thanks @marcoscaceres.
So I think the CSS still need to take that case into consideration.

[deniak]

@fantasai what do you think about that PR?

[fantasai]

The PR is wrong. It'll break forced sidebar ToCs on narrow screens, which is why that code exists in the first place. If the editor of that document is manually adding .toc-sidebar, then that editor needs to stop doing stupid things. PR rejected.

[deniak]

Thanks for the review. I'll ask the editors to remove the class.

[deniak]

After a closer look, it was indeed a bug in respec (w3c/respec#644) that was fixed a month ago