Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save snapshot leaves fixup.js generated content in the saved document #644

Closed
halindrome opened this issue Mar 11, 2016 · 1 comment · Fixed by #688
Closed

Save snapshot leaves fixup.js generated content in the saved document #644

halindrome opened this issue Mar 11, 2016 · 1 comment · Fixed by #688

Comments

@halindrome
Copy link
Contributor

This results in two TOC toggles being inserted. Arguably a bug in fixup.js, but we can address it here too by removing the node with ID toc-nav
halindrome added a commit that referenced this issue Mar 11, 2016
@halindrome
Added code to remove toc-nav node.
89d700d 
If there is a toc-nav node when saving a snapshot, remove it.  It is not
part of the document. It was added by fixup.js.

Should address #644
@halindrome halindrome mentioned this issue Mar 12, 2016
Merged
marcoscaceres pushed a commit that referenced this issue Mar 14, 2016
@halindrome @marcoscaceres
Fix (save-html.js): Added code to remove toc-nav node.
f9ee40f 
If there is a toc-nav node when saving a snapshot, remove it.  It is not
part of the document. It was added by fixup.js.

Should address #644
@deniak deniak mentioned this issue Apr 11, 2016
Closed
@deniak
Copy link
Member

deniak commented Apr 12, 2016

The bug is not entirely fixed. Generated snapshots still end up with a class 'toc-sidebar' in the <body> which is a bug according to @fantasai w3c/tr-design#91 (comment)

@deniak deniak reopened this Apr 12, 2016
@deniak deniak mentioned this issue Apr 12, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove class 'toc-sidebar' from <body> when generating a snapshot w3c/respec
2 participants
@halindrome @deniak