-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Recorded' flag should be renamed in sampled flag #265
Comments
note that the semantics have been changed from de facto sampled a loong time ago. renaming this to a term, but using it differently might be good or confusion causing. it would be better to revert the revert in the process of this, but I suspect people still don't care to make this match defacto #142 (comment) |
What are the semantic differences between recorded and sampled? I thought this was just naming. |
On Wed, Apr 24, 2019 at 3:14 PM Felix Barnsteiner ***@***.***> wrote:
What are the semantic differences between recorded and sampled? I thought
this was just naming.
https://github.com/w3c/trace-context/blob/master/spec/20-http_header_format.md#recorded-flag-00000001
the text wanders around suggesting there is no defined means of what
recorded aka sampled means, when clearly there has been significant
precendent for a trace scoped sampling decision. the text will take you a
while to read and I'd be surprised if you finished feeling you know what
this will do. Take this in comparison with the b3 text
https://github.com/apache/incubator-zipkin-b3-propagation#sampling-state
|
The issue is that w3c spec is trying to squeeze a trinary state into one bit, a theoretical impossibility. It is also trying to accommodate tail-based sampling systems, which in practice don't need the propagation of sampling decision at all. I'd suggest that this section needs another design pass, not just a rename. |
Done in #302 |
As suggested by @yurishkuro in meeting 2019-03-13: The industry term is 'Sampled' and we should stick to that.
The text was updated successfully, but these errors were encountered: