Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Recorded' flag should be renamed in sampled flag #265

Closed
danielkhan opened this issue Mar 22, 2019 · 5 comments
Closed

'Recorded' flag should be renamed in sampled flag #265

danielkhan opened this issue Mar 22, 2019 · 5 comments
Assignees
Labels
Editorial The reported issue can be addressed with an editorial change. This tag could be combined with others
Milestone

Comments

@danielkhan
Copy link
Contributor

As suggested by @yurishkuro in meeting 2019-03-13: The industry term is 'Sampled' and we should stick to that.

@danielkhan danielkhan self-assigned this Mar 22, 2019
@danielkhan danielkhan changed the title 'Recorded' flasg should be renamed in sampled flag 'Recorded' flag should be renamed in sampled flag Mar 22, 2019
@AloisReitbauer AloisReitbauer added this to the 5. PR milestone Apr 23, 2019
@plehegar plehegar added the Editorial The reported issue can be addressed with an editorial change. This tag could be combined with others label Apr 23, 2019
@codefromthecrypt
Copy link

note that the semantics have been changed from de facto sampled a loong time ago. renaming this to a term, but using it differently might be good or confusion causing. it would be better to revert the revert in the process of this, but I suspect people still don't care to make this match defacto #142 (comment)

@felixbarny
Copy link
Contributor

What are the semantic differences between recorded and sampled? I thought this was just naming.

@codefromthecrypt
Copy link

codefromthecrypt commented Apr 24, 2019 via email

@yurishkuro
Copy link
Member

The issue is that w3c spec is trying to squeeze a trinary state into one bit, a theoretical impossibility. It is also trying to accommodate tail-based sampling systems, which in practice don't need the propagation of sampling decision at all. I'd suggest that this section needs another design pass, not just a rename.

@danielkhan
Copy link
Contributor Author

Done in #302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editorial The reported issue can be addressed with an editorial change. This tag could be combined with others
Projects
None yet
Development

No branches or pull requests

6 participants