Improve recorded flag doc #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AloisReitbauer
approved these changes
May 15, 2019
discostu105
approved these changes
May 15, 2019
plehegar
approved these changes
May 15, 2019
plehegar
approved these changes
May 15, 2019
SergeyKanzhelev
approved these changes
May 16, 2019
|
@danielkhan this PR suggested to compress two list items into one. Which totally makes sense as they are repetitive. I haven't seen this change in your PR. So maybe both changes are needed |
|
@SergeyKanzhelev - do you think it would make sense to leave the mutations to the processing model doc. As far as I see, it already contains a similar wording: https://github.com/w3c/trace-context/blob/master/spec/30-processing-model.md |
|
@danielkhan processing model is a non-formative section. Meaning it's an addition to spec, not a replacement. So little duplication is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag was (still?) named "sampling" bit in one place and a paragraph was duplicated which I consolidated. It's still a bit unclear to me however - feel free to clarify it further.
(might be obsoleted with #265)