Fixes wrong headline level of tracestate Header Field Values #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
approved these changes
Mar 27, 2020
mwear
approved these changes
May 5, 2020
arminru
approved these changes
May 6, 2020
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
| @@ -235,7 +235,7 @@ In order to increase interoperability across multiple protocols and encourage su | |||
|
|
|||
| Vendors MUST expect the header name in any case (upper, lower, mixed), and SHOULD send the header name in lowercase. | |||
|
|
|||
| ##### tracestate Header Field Values | |||
| ### Header Values | |||
There was a problem hiding this comment.
this header will be harder to link to directly with anchor links
There was a problem hiding this comment.
That would be the same for Header Name - it isn't unique either and the document processor is smart enough to create
- https://www.w3.org/TR/trace-context/#header-name
and - https://www.w3.org/TR/trace-context/#header-name-0
to distinguish between same headlines.
SergeyKanzhelev
requested changes
Jun 2, 2020
See my reply to your comment. To keep this simple, I am reverting the change of the header names here and will create a new PR later. |
SergeyKanzhelev
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #403
Preview | Diff