Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes wrong headline level of tracestate Header Field Values #404

Merged
merged 3 commits into from
Jun 29, 2020
Merged

Fixes wrong headline level of tracestate Header Field Values #404

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ffe504
fix tracestate level/structure
danielkhan Mar 27, 2020
2fcdb17
Update spec/20-http_request_header_format.md
danielkhan May 19, 2020
88f4db3
Revert change of header names
danielkhan Jun 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions spec/20-http_request_header_format.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ In order to increase interoperability across multiple protocols and encourage su

Vendors MUST expect the header name in any case (upper, lower, mixed), and SHOULD send the header name in lowercase.

##### tracestate Header Field Values
### Header Values
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this header will be harder to link to directly with anchor links

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be the same for Header Name - it isn't unique either and the document processor is smart enough to create


The `tracestate` field may contain any opaque value in any of the keys. Tracestate MAY be sent or received as multiple header fields. Multiple tracestate header fields MUST be handled as specified by <a data-cite='!RFC7230#field.order'>RFC7230 Section 3.2.2 Field Order</a>. The `tracestate` header SHOULD be sent as a single field when possible, but MAY be split into multiple header fields. When sending `tracestate` as multiple header fields, it MUST be split according to <a data-cite='!RFC7230#field.order'>RFC7230</a>. When receiving multiple `tracestate` header fields, they MUST be combined into a single header according to <a data-cite='!RFC7230#field.order'>RFC7230</a>.

Expand All @@ -251,7 +251,7 @@ The `tracestate` field value is a `list` of `list-members` separated by commas (

Empty and whitespace-only list members are allowed. Vendors MUST accept empty `tracestate` headers but SHOULD avoid sending them. Empty list members are allowed in `tracestate` because it is difficult for a vendor to recognize the empty value when multiple `tracestate` headers are sent. Whitespace characters are allowed for a similar reason, as some vendors automatically inject whitespace after a comma separator, even in the case of an empty header.

#### list
##### list

A simple example of a `list` with two `list-member`s might look like:
`vendorname1=opaqueValue1,vendorname2=opaqueValue2`.
Expand All @@ -264,11 +264,11 @@ list-member = OWS

Identifiers for a `list` are short (up to 256 characters) textual identifiers.

#### list-members
##### list-members

A `list-member` contains a key/value pair.

##### Key
###### Key

The key is an identifier that describes the vendor.

Expand All @@ -283,7 +283,7 @@ lcalpha = %x61-7A ; a-z
For multi-tenant vendor scenarios, an at sign (`@`) can be used to prefix the vendor name. Vendors SHOULD set the tenant ID at the beginning of the key. For example, \
`fw529a3039@dt` - `fw529a3039` is a tenant ID and `@dt` is a vendor name. Searching for `@dt=` is more robust for parsing (for example, searching for all a vendor's keys).

##### Value
###### Value

The value is an opaque string containing up to 256 printable ASCII [[!RFC0020]] characters (i.e., the range 0x20 to 0x7E) except comma (`,`) and (`=`). Note that this also excludes tabs, newlines, carriage returns, etc.

Expand All @@ -293,7 +293,7 @@ nblk-chr = %x21-2B / %x2D-3C / %x3E-7E
chr = %x20 / nblk-chr
```

#### Combined Header Value
### Combined Header Value

The `tracestate` value is the concatenation of trace graph key/value pairs

Expand Down