Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo at genericFamilyName #285

Merged
merged 3 commits into from
Dec 26, 2017
Merged

Fixed typo at genericFamilyName #285

merged 3 commits into from
Dec 26, 2017

Conversation

palemieux
Copy link
Contributor

Closes #204

@palemieux palemieux added this to the 3rd Ed milestone Dec 12, 2017
@palemieux palemieux self-assigned this Dec 12, 2017
nigelmegitt
nigelmegitt approved these changes Dec 13, 2017
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial in my opinion, I think you can safely go ahead and merge this.

@andreastai andreastai self-requested a review December 17, 2017 13:38
@palemieux palemieux merged commit 4d7cd57 into master Dec 26, 2017
@palemieux palemieux deleted the issue-204-generic-familyName-typo branch January 4, 2018 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skynavga skynavga skynavga approved these changes

@andreastai andreastai andreastai approved these changes

@nigelmegitt nigelmegitt nigelmegitt approved these changes

Assignees

@palemieux palemieux

Labels
None yet
Projects
None yet
Milestone
3rd Ed CR
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@palemieux @skynavga @andreastai @nigelmegitt