New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add embedded font family test. #201
Comments
…test Add embedded font family test (#201).
The added test checks only for validation of invalid font family names. Still to do:
|
While we can add as many tests as we like, you asked for a test, and the merged PR adds such a test. There is no requirement that says what must be tested or defines completeness with regard to testing. I'm certain that for every test that exists in the TS, you can think of N more tests to add (no matter how large you want to make N). If you want to add more tests, then open new issues along with PRs that satisfy them. In the mean time, I am re-closing this issue. |
I don't agree with @skynavga 's summary from 26 March 2019. This is the generic ticket to add font family tests associated with the normative specification changes in TTML2 from w3c/ttml2#1049. That change introduced 3 individually testable things, and it's my position that we should test all of them:
We have tested only the first one therefore we have not completed this issue. |
Moving follow-on work from #201 (comment) to #254 and re-closing this issue. |
See w3c/ttml2#1049 (comment).
The text was updated successfully, but these errors were encountered: