Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registry profile designator tests (#243). #250

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

skynavga
Copy link
Contributor

Closes #243.

@skynavga skynavga added the enhancement New feature or change request. label Mar 22, 2020
@skynavga skynavga added this to the 2ED milestone Mar 22, 2020
@skynavga skynavga self-assigned this Mar 22, 2020
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cconcolato
Copy link

cconcolato commented Mar 27, 2020

I agree the test matches the text in the spec:

All profile designators which have the TT Profile Namespace as a prefix but are otherwise not listed in Table 5-2 – Profiles or in [TTML Profile Registry] [...] must not appear in a conformant document instance.

But do we expect every validating implementation to have a copy of the profile registry?

@skynavga
Copy link
Contributor Author

But do we expect every validating implementation to have a copy of the profile registry?

Most definitely not. Indeed, that is why we can only attempt a negative test, and, for that matter, we will need to update the registry to explicitly state that we will never define an entry called undefined.

@skynavga skynavga merged commit 5a73952 into master Mar 27, 2020
@skynavga skynavga deleted the issue-0243-imsc-profile-designators branch March 27, 2020 19:55
@skynavga skynavga removed their assignment Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or change request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add imsc profile designator tests.
3 participants