Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IMSC profile designators (#1034). #1123

Merged
merged 4 commits into from
Jul 10, 2019
Merged

Conversation

skynavga
Copy link
Collaborator

Closes #1034.

@skynavga skynavga added this to the 2ED-FPWD milestone Jun 25, 2019
@skynavga skynavga self-assigned this Jun 25, 2019
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is completely contrary to the discussed proposal at #1034 (comment) regarding which @skynavga you seemed to agree, and for which there seemed to be consensus when we discussed it.

@nigelmegitt
Copy link
Contributor

Thanks for addressing #1123 (review) @skynavga , this looks good to me now.

@nigelmegitt
Copy link
Contributor

nigelmegitt commented Jun 26, 2019

I see that the normative reference to the profile registry is dated, which matches our normal policy for normative references, but it does mean that, formally, any new profile added to a future revision of the profile registry is excluded from those permitted, by the text:

All profile designators which have the TT Profile Namespace as a prefix but are otherwise not listed in Table 5-2 – Profiles or in [TTML Media Type], §4, Registry, are reserved for future standardization, and must not appear in a conformant document instance.

This seems contrary to the intention of having a registry. @skynavga can we change the reference link to https://www.w3.org/TR/ttml-profile-registry/ for this reference, exceptionally? Alternatively can we modify the text to say

... or in [TTML Media Type], §4, Registry, or in a future revision of [TTML Media Type], are reserved...

?

@skynavga
Copy link
Collaborator Author

@nigelmegitt ok, I made it generic (exceptionally), and also changed the label used in the bibliography to better match the short name of the document; we should probably discuss this exception in a TTWG call to get approval from the WG;

@skynavga skynavga merged commit 5d4abd9 into master Jul 10, 2019
@skynavga skynavga deleted the issue-1034-add-imsc-designators branch July 10, 2019 01:16
@skynavga skynavga removed their assignment Jul 10, 2019
@skynavga skynavga added the syntax Changes document syntax. label Jul 19, 2019
@skynavga skynavga added the tests Has one or more tests in test suite. label Mar 22, 2020
@skynavga
Copy link
Collaborator Author

Tests at w3c/ttml2-tests#250.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
substantive syntax Changes document syntax. tests Has one or more tests in test suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add IMSC profile designators to Table 5-2.
3 participants