Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featurize offset times w/o metric. #752

Closed
spoeschel opened this issue May 16, 2018 · 3 comments
Closed

Featurize offset times w/o metric. #752

spoeschel opened this issue May 16, 2018 · 3 comments

Comments

@spoeschel
Copy link

spoeschel commented May 16, 2018

Since TTML2, a <time-expression> with offset time may also be specified without a metric, in which case the seconds metric applies. The different #time-offset* features however don't consider this case in any of the syntax subsets.

@skynavga skynavga added this to the CR2 milestone May 16, 2018
@skynavga skynavga changed the title Consider offset <time-expression> w/o metric in features Featurize offset times w/o metric. May 17, 2018
@skynavga skynavga self-assigned this May 17, 2018
@nigelmegitt
Copy link
Contributor

See #113 - that issue was closed without a change. I don't think we actually agreed to make the metric optional, and I recall discussing it and agreeing that it would be a bad idea. However I can not find a documentation trail for that, so it's possible that discussion related to a different metric, e.g. on a length, and that my memory is at fault.

Regardless of that, my preference here would be to revert to the TTML1 specification and make the metric required.

@spoeschel
Copy link
Author

I'm not aware of the history of the introduction of this change, but I would prefer to not have the ability to omit the metric as well. It is imprecise to not specify it and less easier to read for humans (possibly requires a spec lookup to be sure about that "default metric"). And of course it is not too expensive to specifiy it.

@css-meeting-bot
Copy link
Member

The Working Group just discussed Featurize offset times w/o metric. ttml2#752, and agreed to the following:

  • SUMMARY: @skynavga to prepare a pull request to remove the optionality of metric on time expressions
The full IRC log of that discussion <nigel> Topic: Featurize offset times w/o metric. ttml2#752
<nigel> github: https://github.com//issues/752
<nigel> Glenn: I'll prepare a pull request to bring this back to TTML1 syntax by removing the
<nigel> .. optionality of metric. Then we can hold off on review until the pull request stage.
<nigel> Nigel: Sounds good.
<nigel> SUMMARY: @skynavga to prepare a pull request to remove the optionality of metric on time expressions

skynavga added a commit that referenced this issue May 17, 2018
skynavga added a commit that referenced this issue May 31, 2018
@skynavga skynavga removed their assignment May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants