Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert optionality of metric (#752). #768

Merged
merged 2 commits into from
May 31, 2018
Merged

Revert optionality of metric (#752). #768

merged 2 commits into from
May 31, 2018

Conversation

skynavga
Copy link
Collaborator

Closes #752.

@skynavga skynavga added this to the CR2 milestone May 17, 2018
@skynavga skynavga self-assigned this May 17, 2018
@skynavga skynavga requested a review from nigelmegitt May 17, 2018 23:33
nigelmegitt
nigelmegitt reviewed May 18, 2018
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my preferred resolution to the issue. Do the schemas need to be updated to match?

@skynavga
Copy link
Collaborator Author

No, schemas don't need updating.

@skynavga skynavga merged commit f3e9b2e into master May 31, 2018
@skynavga skynavga removed their assignment May 31, 2018
@skynavga skynavga deleted the issue-0752-revert-metric-optionality branch June 28, 2018 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nigelmegitt nigelmegitt nigelmegitt approved these changes

Assignees
No one assigned
Labels
substantive
Projects
None yet
Milestone
1ED-CR2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skynavga @nigelmegitt