Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #rubyAlign features. #793

Closed
skynavga opened this issue May 24, 2018 · 2 comments
Closed

Refactor #rubyAlign features. #793

skynavga opened this issue May 24, 2018 · 2 comments
Labels
pr merged early substantive
Milestone
1ED-CR2

Comments

@skynavga
Copy link
Collaborator

The current definition of #rubyAlign related features is quite awkward, and needs refactored as:

#rubyAlign-no-withBase = ruby align values except withBase
#rubyAlign-withBase = ruby align value withBase
#rubyAlign = #rubyAlign-no-withBase + #rubyAlign-withBase

See also
@skynavga skynavga added this to the CR2 milestone May 24, 2018
@skynavga skynavga self-assigned this May 24, 2018
@skynavga skynavga mentioned this issue May 24, 2018
Closed
skynavga added a commit that referenced this issue May 24, 2018
@skynavga
Clean up and refactor features (#688, #763, #789, #790, #791, #792, #793
b696679 
).
@skynavga skynavga mentioned this issue May 24, 2018
Merged
@nigelmegitt
Copy link
Contributor

I'm happy to go ahead with refactoring this, but I object to using #rubyAlign-no-withbase - this needs to be a positive feature designator whose meaning would remain clear if in the future we want to extend. I would propose calling it #rubyAlign-minimal and explicitly state that it implies support for the values "start" | "center" | "end" | "spaceAround" | "spaceBetween".

@skynavga skynavga removed their assignment Jun 4, 2018
@skynavga
Copy link
Collaborator Author

skynavga commented Jun 7, 2018

Merged early per WG resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pr merged early substantive
Projects
None yet
Milestone
1ED-CR2
Development

No branches or pull requests
2 participants
@skynavga @nigelmegitt