Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #condition features. #790

Closed
skynavga opened this issue May 23, 2018 · 2 comments
Closed

Refactor #condition features. #790

skynavga opened this issue May 23, 2018 · 2 comments
Labels
pr merged early substantive
Milestone
1ED-CR2

Comments

@skynavga
Copy link
Collaborator

The current definition of #condition related features is quite awkward, and needs refactored as:

#condition-no-media = condition expressions without media() function
#condition-media = condition expressions with media() function
#condition = #condition-no-media + #condition-media
@skynavga skynavga added this to the CR2 milestone May 23, 2018
@skynavga skynavga self-assigned this May 23, 2018
skynavga added a commit that referenced this issue May 24, 2018
@skynavga
Clean up and refactor features (#688, #763, #789, #790, #791, #792, #793
b696679 
).
@skynavga skynavga mentioned this issue May 24, 2018
Merged
@nigelmegitt
Copy link
Contributor

Sorry I've had no time to catch up with this and comment on it, but I don't agree that #condition should be refactored in a way that introduces a negative feature designator. I do agree that #condition should be refactored though, just that it should be the sum of a set of positive features, specifically:

  • #condition-fn-media - supports <media-function>
  • #condition-fn-parameter - supports <parameter-function>
  • #condition-fn-supports - supports <supports-function>
  • #condition-primary - supports primary (non function) expressions.

skynavga added a commit that referenced this issue Jun 4, 2018
@skynavga
Merge pull request #794 from w3c/issue-0763-refactor-v1-features
8122ba8 
Clean up and refactor features (#688, #763, #789, #790, #791, #792, #…
@skynavga skynavga removed their assignment Jun 4, 2018
@skynavga
Copy link
Collaborator Author

skynavga commented Jun 7, 2018

Merged early per WG resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pr merged early substantive
Projects
None yet
Milestone
1ED-CR2
Development

No branches or pull requests
2 participants
@skynavga @nigelmegitt