Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify application of font variant (#1084). #1085

Merged
merged 1 commit into from
Jun 23, 2019

Conversation

skynavga
Copy link
Collaborator

Closes #1084.

@skynavga skynavga added this to the 2ED-FPWD milestone May 24, 2019
@skynavga skynavga self-assigned this May 24, 2019
Copy link
Contributor

@palemieux palemieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is now clear that tts:fontVariant does not apply to ruby containers, which cannot contain child glyph areas, these ruby containers should be removed from the list of elements to which this style property applies (see #1043 and #1071).

@skynavga
Copy link
Collaborator Author

Regarding #1085 (review), a ruby container is not an element, and, therefore, cannot be removed from the set { span }. You comment is non-actionable.

@css-meeting-bot
Copy link
Member

The Timed Text Working Group just discussed font variant.

The full IRC log of that discussion <cyril> Topic: font variant
<cyril> github: https://github.com//pull/1085
<cyril> pal: same for me
<cyril> nigel: I don't have an objection
<cyril> ... anyone has an objection>
<cyril> s/>/?/
<cyril> ... none
<cyril> ... we're happy to accept this

Copy link
Contributor

@palemieux palemieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not resolve #1043 but provides a valuable clarification.

@skynavga skynavga merged commit d2ef4c6 into master Jun 23, 2019
@skynavga skynavga deleted the issue-1084-font-variant-application branch June 23, 2019 08:33
@skynavga skynavga removed their assignment Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application semantics of font variant.
4 participants