Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary: @palemieux review request for combined pull requests #1122

Closed
wants to merge 18 commits into from

Conversation

skynavga
Copy link
Collaborator

As a favor to @palemieux, and one I don't expect to repeat since @palemieux could have done this himself in a private branch, I have combined the following independent PRs, which have been approved by all parties, either in a WG teleconference, or in comments on the PR, into this temporary branch and temporary PR for the purpose of review only. After a reasonable amount of time, which I judge to be until Thursday 06/27, @palemieux and others may review the combine changes of these PRs.

Note: the changes contained in these PRs are entirely independent and do not intersect in the specification text.

If I don't see approvals or an objection filed by 06/27, I will dismiss the procedural holds that have been placed on these PRs by @palemieux (which do not request any change), and proceed with merging them into the master branch.

After merger, I will remove this temporary branch and close this PR.

@skynavga skynavga requested a review from palemieux June 22, 2019 03:06
@skynavga skynavga changed the title pal review request for combined pull requests Temporary: @palemieux review request for combined pull requests Jun 22, 2019
@palemieux
Copy link
Contributor

@skynavga I have added questions at #1101

@skynavga skynavga closed this Jul 4, 2019
@skynavga skynavga deleted the ga/pal-review-request branch July 4, 2019 16:13
@nigelmegitt nigelmegitt restored the ga/pal-review-request branch July 4, 2019 16:18
@skynavga skynavga deleted the ga/pal-review-request branch August 29, 2019 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants