New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary: @palemieux review request for combined pull requests #1122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tainer-span-styles
…cation' into ga/pal-review-request
…tion' into ga/pal-review-request
…gy-application' into ga/pal-review-request
…ion' into ga/pal-review-request
…ion' into ga/pal-review-request
…tion-table' into ga/pal-review-request
…tyles' into ga/pal-review-request
skynavga
changed the title
pal review request for combined pull requests
Temporary: @palemieux review request for combined pull requests
Jun 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a favor to @palemieux, and one I don't expect to repeat since @palemieux could have done this himself in a private branch, I have combined the following independent PRs, which have been approved by all parties, either in a WG teleconference, or in comments on the PR, into this temporary branch and temporary PR for the purpose of review only. After a reasonable amount of time, which I judge to be until Thursday 06/27, @palemieux and others may review the combine changes of these PRs.
Note: the changes contained in these PRs are entirely independent and do not intersect in the specification text.
If I don't see approvals or an objection filed by 06/27, I will dismiss the procedural holds that have been placed on these PRs by @palemieux (which do not request any change), and proceed with merging them into the master branch.
After merger, I will remove this temporary branch and close this PR.