-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 0203 add examples of ja features part 2 #273
Issue 0203 add examples of ja features part 2 #273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for requesting review @nigelmegitt. It's good to see these coming through. I'd pefer to review this closely in the doc though, where i can read the code more easily and see more of the surrounding text, and where also others who get the issue notifications (esp. the i18n WG) can follow the thread. Is that ok? For smaller edits, i'd be happy to sign off here, but this is quite a big change.
@r12a You can view this version of the doc (for this pull request) at https://rawgit.com/w3c/ttml2/b4ad18b81c329bb317a2158e15699820cb5e95b3/spec/ttml2.html#style-attribute-ruby (fragment id gets you near to the main changes) |
I began looking. I continue when back in the office next week. One observation for now. In Example Fragment – Ruby Overflow some of the angle brackets are the wrong way round. |
…amples-of-ja-features-part-2
I took another look. I think it's mostly ok, and thanks for adding that. A couple of comments: Looking at http://w3c.github.io/ttml2/spec/ttml2.html#ruby-position-example-1
If you take a decision on that, then i think we could probably close this issue. If anything else crops up, i can raise it as a separate issue, but the main request for addition of examples appears to be done. |
See: #203