Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 0203 add examples of ja features part 2 #273

Merged
merged 3 commits into from
May 3, 2017

Conversation

dae-kim
Copy link
Contributor

@dae-kim dae-kim commented Mar 3, 2017

See: #203

Copy link

@r12a r12a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for requesting review @nigelmegitt. It's good to see these coming through. I'd pefer to review this closely in the doc though, where i can read the code more easily and see more of the surrounding text, and where also others who get the issue notifications (esp. the i18n WG) can follow the thread. Is that ok? For smaller edits, i'd be happy to sign off here, but this is quite a big change.

@nigelmegitt
Copy link
Contributor

@r12a You can view this version of the doc (for this pull request) at https://rawgit.com/w3c/ttml2/b4ad18b81c329bb317a2158e15699820cb5e95b3/spec/ttml2.html#style-attribute-ruby (fragment id gets you near to the main changes)

@r12a
Copy link

r12a commented Mar 10, 2017

I began looking. I continue when back in the office next week.

One observation for now. In Example Fragment – Ruby Overflow some of the angle brackets are the wrong way round.

@nigelmegitt
Copy link
Contributor

Meeting 2017-04-27: @skynavga to review for correctness, @r12a to be "pinged" since it looks as though he was part way through reviewing this.

@skynavga skynavga merged commit c88571c into gh-pages May 3, 2017
@r12a
Copy link

r12a commented May 8, 2017

I took another look. I think it's mostly ok, and thanks for adding that. A couple of comments:

Looking at http://w3c.github.io/ttml2/spec/ttml2.html#ruby-position-example-1

  • it would be much easier to read if meaningful style names were used, rather than s4, which you have to look up to read the code. How about just naming them 'ruby', 'rt', etc?
  • i think i would have preferred to see a single string with annotations on both sides, rather than two separate strings, with one annotation each, which looks quite wierd to me.

If you take a decision on that, then i think we could probably close this issue. If anything else crops up, i can raise it as a separate issue, but the main request for addition of examples appears to be done.

@skynavga skynavga removed their assignment May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants