Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve definition of related media object region (#360). #534

Merged
merged 4 commits into from
Jan 15, 2018

Conversation

skynavga
Copy link
Collaborator

@skynavga skynavga commented Jan 3, 2018

Closes #360.

@skynavga skynavga self-assigned this Jan 3, 2018
@skynavga skynavga added this to the Editor's CR Work List milestone Jan 3, 2018
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally a helpful change, a couple of small points to address.

spec/ttml2.xml Outdated
<loc href="#terms-document-coordinate-space">document coordinate space</loc> correspond exactly with
<emph>presentation pixels</emph> in the <loc href="#terms-presentation-context-coordinate-space">presentation context coordinate space</loc>;
however, such an exact correspondence need not apply, and, in particular, the (implementation defined) mapping between these coordinate spaces
may be subject to a transformation of pixel aspect ratios, resolutions, color spaces, and color sample depths.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need an "etc." on this list - I'm thinking of gamma and pixel layout for example, but the list probably isn't worth describing fully, even if that were possible.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, will add "etc"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

spec/ttml2.xml Outdated
<gitem id="terms-presentation-processing-context">
<label>[presentation processing context]</label>
<def>
<p>A hypothetical display device on which the <loc href="#terms-root-container-region">root container region</loc> and a non-null, visual
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why must there be a non-null related media object? It would be reasonable to have a visual presentation processing context used to present captions against an audio only related media object for example, which would therefore be absent from the presentation context, assuming the presentation context is visual.

Of course it is also possible to present a TTML document in a presentation context with no related media object at all.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, can allow non-visual or null RMOs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@skynavga
Copy link
Collaborator Author

@nigelmegitt please check fixes

@skynavga skynavga merged commit 18011f0 into master Jan 15, 2018
@skynavga skynavga removed their assignment Jan 15, 2018
@skynavga skynavga deleted the issue-0360-related-media-object-region branch March 9, 2018 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants