-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve definition of related media object region (#360). #534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally a helpful change, a couple of small points to address.
spec/ttml2.xml
Outdated
<loc href="#terms-document-coordinate-space">document coordinate space</loc> correspond exactly with | ||
<emph>presentation pixels</emph> in the <loc href="#terms-presentation-context-coordinate-space">presentation context coordinate space</loc>; | ||
however, such an exact correspondence need not apply, and, in particular, the (implementation defined) mapping between these coordinate spaces | ||
may be subject to a transformation of pixel aspect ratios, resolutions, color spaces, and color sample depths.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably need an "etc." on this list - I'm thinking of gamma and pixel layout for example, but the list probably isn't worth describing fully, even if that were possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree, will add "etc"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
spec/ttml2.xml
Outdated
<gitem id="terms-presentation-processing-context"> | ||
<label>[presentation processing context]</label> | ||
<def> | ||
<p>A hypothetical display device on which the <loc href="#terms-root-container-region">root container region</loc> and a non-null, visual |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why must there be a non-null related media object? It would be reasonable to have a visual presentation processing context used to present captions against an audio only related media object for example, which would therefore be absent from the presentation context, assuming the presentation context is visual.
Of course it is also possible to present a TTML document in a presentation context with no related media object at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, can allow non-visual or null RMOs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@nigelmegitt please check fixes |
Closes #360.