Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable inline ruby presentation based on document processing context (#255). #617

Merged
merged 6 commits into from
Feb 15, 2018

Conversation

cconcolato
Copy link
Contributor

closes #255

spec/ttml2.xml Outdated
@@ -11553,13 +11557,7 @@ computed value of <att>tts:ruby</att> of exactly one sibling is <code>delimiter<
<item><p>if the computed value of <att>tts:ruby</att> is <code>delimiter</code>, then the
computed value of <att>tts:ruby</att> of no descendant element is not <code>none</code>;</p></item>
</ulist>
<p>A validating processor must treat a violation of any of the above constraints as an error.
For the purpose of presentation processing, the violation of any of these constraints should result in fallback (inline)
presentation of ruby text annotations.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cconcolato Why remove this recommendation for fallback in the case of the constraints being validated? It seems like it would still be worth including that statement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out. I wasn't sure about it. I checked the rest of the spec and we don't tell implementation what to do in case of error. Given that we now have a clear way for implementation to do inline I did not see the need to specify that. It encourages the use of invalid content in general because it will work in implementations not supporting full presentation.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cconcolato actually we specify fallback behavior in many error cases, and I think it important we do it more (not less); I don't think it encourages the use of invalid content at all, but creates more consistency among implementations

@cconcolato
Copy link
Contributor Author

@nigelmegitt @skynavga Added the sentence back. Can you review again?

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@skynavga skynavga removed the agenda label Feb 15, 2018
@skynavga skynavga changed the title enable inline ruby presentation based on document processing context Enable inline ruby presentation based on document processing context (#255). Feb 15, 2018
@cconcolato cconcolato merged commit c7baaaf into master Feb 15, 2018
@skynavga skynavga deleted the issue-0255-ruby-inline branch March 9, 2018 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How would someone display ruby inline?
4 participants