Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #image-png-hdr-pq feature (#695). #816

Closed
wants to merge 3 commits into from

Conversation

skynavga
Copy link
Collaborator

@skynavga skynavga commented Jun 7, 2018

Closes #695.

@skynavga
Copy link
Collaborator Author

skynavga commented Jun 7, 2018

@nigelmegitt @palemieux I suggest we go ahead and approve this, but mark as risk for CR2. That way, we can pull it out if we find out we can't normatively reference the WG Note.

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not comfortable with this as is and would like to adopt the previously mentioned (and reiterated here) proposal to reference PNG-HDR-PQ informatively and BT2100 normatively, to make this feature more generally useful and less brittle.

of content type <code>image/png</code> as defined by <bibref ref="png-hdr-pq"/>.</p>
<p>A TTML <loc href="#terms-presentation-processor">presentation processor</loc> supports the <code>#image-png-hdr-pq</code>
feature if it implements presentation semantic support for <loc href="#terms-image-resource">image resources</loc>
of content type <code>image/png</code> as defined by <bibref ref="png-hdr-pq"/>.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concerns have been raised that the approach taken in the PQ HDR in PNG WG Note is brittle because it uses a "magic string" to identify the ICC profile. The idea is that there should be a better or more standard way to make PQ values from a PNG in the future. I propose that we extend this feature to cover any PNG constructed to generate PQ pixel values and revert the reference to being normative, of the form "Note that [REF] defines a mechanism for storing images that use the Reference PQ EOTF specified in [BT2100-1] in the Portable Network Graphics (PNG) format" and that we add a normative reference to BT2100 as the definition of PQ.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I'm concerned, that is a veto of adding any #image-png-hdr-pq at this time. The intent of defining an HDR image feature is to point at a concrete (and not any) format. If there is none, then we can't proceed at all with defining a related feature.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skynavga we can indeed point at one, but the definition of PQ HDR is not in the image format but in BT2100. We do not need a normative reference to an image format to define an image feature that relates to the output pixels generated when processing an image. An informative example to a single example is acceptable in my view.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nigelmegitt I cannot agree.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skynavga I don't really understand which part of this you're not agreeing with, so a bit more information would be helpful. In the meantime, closing this is likely to push us to creating an extension in IMSC 1.1 that does the same thing as I'm proposing above.

@skynavga
Copy link
Collaborator Author

skynavga commented Jun 8, 2018

Based on @nigelmegitt veto of this proposal, I am closing this PR, and recommend that #695 be closed and marked with ttml.next label.

@skynavga skynavga closed this Jun 8, 2018
@skynavga skynavga removed their assignment Jun 21, 2018
@skynavga skynavga deleted the issue-0695-image-png-hdr-pq branch June 28, 2018 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants