Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure audio and image (in presentation contexts) are treated as cont… #898

Merged
merged 2 commits into from
Jul 20, 2018

Conversation

skynavga
Copy link
Collaborator

…ent elements (#891).

Closes #891.

@skynavga skynavga self-assigned this Jul 15, 2018
@skynavga skynavga added this to the PR milestone Jul 15, 2018
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems right to me, though I am not convinced that we can claim it is editorial. I'm approving it now but it would be appropriate to give this pull request the full review period and not merge early as an editorial pull request.

@skynavga
Copy link
Collaborator Author

Taking a conservative position, I am relabeling this as substantive.

@skynavga skynavga modified the milestones: PR, CR3 Jul 19, 2018
@skynavga skynavga removed the agenda label Jul 19, 2018
@css-meeting-bot
Copy link
Member

The Working Group just discussed Ensure audio and image (in presentation contexts) are treated as cont… ttml2#898.

The full IRC log of that discussion <nigel> Topic: Ensure audio and image (in presentation contexts) are treated as cont… ttml2#898
<nigel> github: https://github.com//pull/898
<nigel> Glenn: I think I just wanted to note that I've moved this to substantive. We discussed earlier.
<nigel> .. Pierre, you might want to take a look at this. It adds audio and image to content element.
<nigel> .. During the last meeting you had some questions and were reluctant to make this change.
<nigel> Pierre: Alright, em...
<nigel> Glenn: I went through all instances of the phrase content element in TTML2 and found
<nigel> .. no cases where it was not appropriate.
<nigel> Pierre: I sense that we've already had this discussion somehow and you argued for the
<nigel> .. opposite in the past, but you've done the research now?
<nigel> Glenn: Yes. It took me about a day!
<nigel> Pierre: I need time to think about it. I'll study it.
<nigel> .. You're saying it's not embedded content, just content?
<nigel> Glenn: It's still covered under embedded but also in content element. We already had
<nigel> .. "presentation related" which included image but not audio. This attempts to make it
<nigel> .. consistent.
<nigel> Pierre: I'll add this to my review list, thanks for pointing me to it explicitly.

@skynavga skynavga merged commit 2535899 into master Jul 20, 2018
@skynavga skynavga removed their assignment Jul 20, 2018
@skynavga
Copy link
Collaborator Author

Merged early per WG resolution to move to CR3 CfC.

@skynavga skynavga deleted the issue-0891-audio-and-image branch October 4, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants