Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial improvements for 'content element' usage (#892). #899

Merged
merged 4 commits into from
Jul 23, 2018

Conversation

skynavga
Copy link
Collaborator

Closes #892.

@skynavga skynavga added this to the PR milestone Jul 15, 2018
@skynavga skynavga self-assigned this Jul 15, 2018
@@ -1314,8 +1314,7 @@ abbreviated as <emph>ipd</emph> or <emph>IPD</emph>.</p>
<p>A <loc href="#terms-region">region</loc> that is defined in an inline manner with respect to some
<loc href="#terms-content-element">content element</loc> to be selected into (targeted to) the region.
An inline region is specified either explicitly by a <loc href="#layout-vocabulary-region"><el>region</el></loc> element child of
a <loc href="#terms-content-element">content element</loc> or implicitly by specifying a <loc href="#style-attribute-extent">tts:extent</loc>
or <loc href="#style-attribute-origin">tts:origin</loc> style attribute on a <loc href="#terms-content-element">content element</loc>.
certain <loc href="#terms-content-element">content elements</loc>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this deletion come from another branch?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. The text "or implicitly ..." was removed because we no longer have implicit inline regions; rather, we have implied region animation. That is to say, we now only have explicit inline regions.

spec/ttml2.xml Outdated
@@ -16829,8 +16828,8 @@ defined to be coterminous with the <loc href="#terms-root-temporal-extent">root
<p>The <el>region</el> element is used to define a rectangular space or area into which content is
to be flowed for the purpose of presentation.</p>
<p>A <el>region</el> element may appear as either (1) a child of a
<loc href="#layout-vocabulary-layout">layout</loc> element or (2) a child of block level
<loc href="#terms-content-element">content element</loc>, specifically, of elements
<loc href="#layout-vocabulary-layout">layout</loc> element or (2) a child of certain block level
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just say (2) a child of an element in the <loc href="#element-vocab-group-block">Block.class</loc> element group ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because image in a block context, e.g., child of div, is block level content element but is not a member of Block.class.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then the text on line 16832-3 that says "specifically, of elements in the Block.class element group" must change, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, will update

@skynavga skynavga modified the milestones: PR, CR3 Jul 19, 2018
@skynavga skynavga removed the agenda label Jul 19, 2018
@css-meeting-bot
Copy link
Member

The Working Group just discussed Editorial improvements for 'content element' usage (#892). ttml2#899.

The full IRC log of that discussion <nigel> Topic: Editorial improvements for 'content element' usage (#892). ttml2#899
<nigel> github: https://github.com//pull/899
<nigel> Glenn: This is a small number of editorial improvements.
<nigel> .. Nigel you have an outstanding comment I need to look at.
<nigel> Nigel: Yes
<nigel> Glenn: We can do this offline.
<nigel> Nigel: Ok

@skynavga
Copy link
Collaborator Author

@nigelmegitt please re-review

@skynavga
Copy link
Collaborator Author

Merged early per WG resolution to move forward with CR3 CfC.

@skynavga skynavga deleted the issue-0892-content-element branch October 4, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants