-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove #textOrientation-sideways-LR and related semantics (#980). #981
Remove #textOrientation-sideways-LR and related semantics (#980). #981
Conversation
The Timed Text Working Group just discussed
The full IRC log of that discussion<nigel> Topic: Remove #textOrientation-sideways-LR and related semantics (#980). ttml2#981<nigel> github: https://github.com//pull/981 <nigel> Glenn: Summary here is that sideways-left is not well defined and problematic because <nigel> .. in our top to bottom inline progression direction vertical writing directions, if you turn <nigel> .. English text on the side to the left, then the first letter of the sentence appears at the <nigel> .. bottom of the screen and proceeds from bottom to top. The alternative is to do them <nigel> .. top to bottom and have a partial mirror image of the text vertically, which would be <nigel> .. hard to read. When I reviewed CSS writing modes level 3 and UTR50 the conclusion I <nigel> .. reached is that sideways-left is not well defined. I could implement it but it wouldn't <nigel> .. make any sense and it would be a waste of effort. If I implemented it so it starts at the <nigel> .. bottom and goes to the top then it contradicts the writing mode definition, without <nigel> .. introducing a new bottom to top writing mode. This is marked as at risk so my response <nigel> .. is to remove this and improve the consistency with CSS. It's substantive because it takes <nigel> .. out both sideways-left and sideways-right, leaving mixed, upright and sideways, where <nigel> .. sideways always means clockwise, which matches CSS. If we are going to make this <nigel> .. substantive change we have to do it under the rubrick of changing or removing an at <nigel> .. risk feature. I need someone to review it. <nigel> .. TTPE is not going to implement it so at the end we will end up with a red box in the <nigel> .. implementation matrix. <nigel> Nigel: Thank you for raising this, and for inviting @r12a to review it. I'd be interested to <nigel> .. hear his comments. <nigel> .. I can't recall how this got in to our spec. <nigel> Glenn: It was in a previous version of a CSS spec but was removed, probably because it <nigel> .. doesn't make any sense for top to bottom layout. <nigel> Pierre: Digital Cinema implementations support left and right rotation, but that does not <nigel> .. mean it is used. I'm not objecting to the removal, just adding a data point as to why we <nigel> .. may have ended up with this. <nigel> Glenn: That's fired a neuron in my mind, so it's probably the case. <nigel> Nigel: I see Pierre just approved it. We have time to let this pull request run its course in <nigel> .. terms of review so I suggest we allow that. <nigel> SUMMARY: Pull request review to continue. |
I believe this is in line with the recommendations in https://github.com/w3c/ttml2/issues/277. On that basis, i agree with it. |
<p>If the value of this attribute is <code>sidewaysLeft</code>, then rotated <loc href="#terms-glyph-area">glyph areas</loc> | ||
are rotated 90° counter-clockwise.</p> | ||
<p>If the value of this attribute is <code>sidewaysRight</code>, then rotated <loc href="#terms-glyph-area">glyph areas</loc> | ||
<p>If the value of this attribute is <code>sideways</code>, then all <loc href="#terms-glyph-area">glyph areas</loc> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting this is a change to the definition of sideways
, in that it is no longer block progression direction dependent.
@@ -13417,22 +13414,16 @@ property has no effect.</p> | |||
they are rotated or not rotated in vertical writing modes, where this determination is made in accordance with the <code>Vertical_Orientation</code> | |||
of each content character as determined by <bibref ref="utr50"/>.</p> | |||
<p>If the value of this attribute is <code>mixed</code>, then rotated <loc href="#terms-glyph-area">glyph areas</loc> are set sideways | |||
and non-rotated <loc href="#terms-glyph-area">glyph areas</loc> are set upright, where <emph>sideways</emph> means rotated either 90° clockwise | |||
or 90° count-clockwise, respectively, in accordance with whether the applicable block progression direction is right-to-left or left-to-right, | |||
and non-rotated <loc href="#terms-glyph-area">glyph areas</loc> are set upright, where <emph>sideways</emph> means rotated 90° clockwise, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for a potential editorial tweak at some point in the future: we define sideways in relation to mixed
independently of the keyword sideways
even though both have exactly the same definition, rotate 90º clockwise, so potentially we could make them both reference the same definition and define the behaviour in one place rather than two. Very minor point!
Closes #980.