Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove #textOrientation-sideways-LR and related semantics (#980). #981

Merged
merged 3 commits into from
Sep 9, 2018
Merged

Remove #textOrientation-sideways-LR and related semantics (#980). #981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c516ca
Remove #textOrientation-sideways-LR and related semantics (#980).
skynavga Aug 26, 2018
deb8350
Sidways always means rotate 90CW (#980).
skynavga Aug 27, 2018
552fc42
Merge branch 'master' into issue-0980-remove-text-orientation-sideway…
skynavga Sep 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified spec/images/textOrientation.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion spec/profiles/ttml2-full.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,6 @@
<feature value="required">#textEmphasis-minimal</feature>
<feature value="required">#textEmphasis-quoted-string</feature>
<feature value="required">#textOrientation</feature>
<feature value="required">#textOrientation-sideways-LR</feature>
<feature value="required">#textOutline</feature>
<feature value="required">#textOutline-blurred</feature>
<feature value="required">#textOutline-unblurred</feature>
Expand Down
1 change: 0 additions & 1 deletion spec/profiles/ttml2-presentation.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,6 @@
<feature value="optional">#textEmphasis-minimal</feature>
<feature value="optional">#textEmphasis-quoted-string</feature>
<feature value="optional">#textOrientation</feature>
<feature value="optional">#textOrientation-sideways-LR</feature>
<feature value="optional">#textOutline</feature>
<feature value="optional">#textOutline-blurred</feature>
<feature value="optional">#textOutline-unblurred</feature>
Expand Down
1 change: 0 additions & 1 deletion spec/profiles/ttml2-transformation.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@
<feature value="optional">#textEmphasis-minimal</feature>
<feature value="optional">#textEmphasis-quoted-string</feature>
<feature value="optional">#textOrientation</feature>
<feature value="optional">#textOrientation-sideways-LR</feature>
<feature value="optional">#textOutline</feature>
<feature value="optional">#textOutline-blurred</feature>
<feature value="optional">#textOutline-unblurred</feature>
Expand Down
2 changes: 0 additions & 2 deletions spec/rnc/ttml2-datatypes.rnc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,8 +437,6 @@ TTAF.TextEmphasis.datatype =
TTAF.TextOrientation.datatype =
"mixed" |
"sideways" |
"sidewaysLeft" |
"sidewaysRight" |
"upright"

TTAF.TextOutline.datatype =
Expand Down
1 change: 0 additions & 1 deletion spec/status.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ report</loc>. For each feature introduced in this specification:</p>
<item><p><loc href="#feature-shear">#shear</loc></p></item>
<item><p><loc href="#feature-speak">#speak</loc></p></item>
<item><p><loc href="#feature-speech">#speech</loc></p></item>
<item><p><loc href="#feature-textOrientation-sideways-LR">#textOrientation-sideways-LR</loc></p></item>
<item><p><loc href="#feature-validation">#validation</loc></p></item>
</ulist>

Expand Down
39 changes: 4 additions & 35 deletions spec/ttml2.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1781,9 +1781,8 @@ active time interval of the feature.</p>
<label>[text orientation]</label>
<def>
<p>A characterization of the orientation of a <loc href="#terms-glyph-area">glyph area</loc> in terms of degrees of rotation, where
0&deg; designates an <code>upright</code> orientation,
90&deg;, i.e, 90 degrees clockwise, designates a <code>sidewaysRight</code> orientation, and
270&deg;, i.e, 90 degrees counter-clockwise, designates a <code>sidewaysLeft</code> orientation,
0&deg; designates an <code>upright</code> orientation and
90&deg;, i.e, 90 degrees clockwise, designates a <code>sideways</code> orientation,
about which see also <specref ref="style-attribute-textOrientation"/>.</p>
</def>
</gitem>
Expand Down Expand Up @@ -13377,8 +13376,6 @@ by content flowed into a region to which a vertical writing mode applies.</p>
<td>
<code>"mixed"</code> |
<code>"sideways"</code> |
<code>"sidewaysLeft"</code> |
<code>"sidewaysRight"</code> |
<code>"upright"</code>
</td>
</tr>
Expand Down Expand Up @@ -13417,22 +13414,16 @@ property has no effect.</p>
they are rotated or not rotated in vertical writing modes, where this determination is made in accordance with the <code>Vertical_Orientation</code>
of each content character as determined by <bibref ref="utr50"/>.</p>
<p>If the value of this attribute is <code>mixed</code>, then rotated <loc href="#terms-glyph-area">glyph areas</loc> are set sideways
and non-rotated <loc href="#terms-glyph-area">glyph areas</loc> are set upright, where <emph>sideways</emph> means rotated either 90&deg; clockwise
or 90&deg; count-clockwise, respectively, in accordance with whether the applicable block progression direction is right-to-left or left-to-right,
and non-rotated <loc href="#terms-glyph-area">glyph areas</loc> are set upright, where <emph>sideways</emph> means rotated 90&deg; clockwise,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for a potential editorial tweak at some point in the future: we define sideways in relation to mixed independently of the keyword sideways even though both have exactly the same definition, rotate 90º clockwise, so potentially we could make them both reference the same definition and define the behaviour in one place rather than two. Very minor point!

and where <emph>upright</emph> means not rotated.</p>
<note role="clarification">
<p>According to <bibref ref="utr50"/>, visual rotation of a <loc href="#terms-glyph-area">glyph areas</loc> may occur through either the substitution
of a rotated <loc href="#terms-glyph-area">glyph areas</loc> or by performing an affine rotation transformation on the
<loc href="#terms-glyph-area">glyph areas</loc>'s outline (or raster image),
where the determination of which of these applies depends on the specific font used during presentation processing.</p>
</note>
<p>If the value of this attribute is <code>sidewaysLeft</code>, then rotated <loc href="#terms-glyph-area">glyph areas</loc>
are rotated 90&deg; counter-clockwise.</p>
<p>If the value of this attribute is <code>sidewaysRight</code>, then rotated <loc href="#terms-glyph-area">glyph areas</loc>
<p>If the value of this attribute is <code>sideways</code>, then all <loc href="#terms-glyph-area">glyph areas</loc>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting this is a change to the definition of sideways, in that it is no longer block progression direction dependent.

are rotated 90&deg; clockwise.</p>
<p>If the value of this attribute is <code>sideways</code>, then rotated <loc href="#terms-glyph-area">glyph areas</loc>
are rotated either 90&deg; clockwise or 90&deg; count-clockwise, respectively,
in accordance with whether the applicable block progression direction is right-to-left or left-to-right.</p>
<p>If the value of this attribute is <code>upright</code>, then all characters are considered
to have a vertical orientation of <code>U</code>, in which case no
<loc href="#terms-glyph-area">glyph areas</loc> are rotated. In this case the
Expand All @@ -13459,7 +13450,6 @@ example.</p>
&lt;p region="vertical"&gt;
&lt;span <phrase role="strong">tts:textOrientation="mixed"</phrase>&gt;A&lt;/span&gt;
&lt;span <phrase role="strong">tts:textOrientation="upright"</phrase>&gt;B&lt;/span&gt;
&lt;span <phrase role="strong">tts:textOrientation="sidewaysLeft"</phrase>&gt;C&lt;/span&gt;
&lt;/p&gt;
</eg>
</td>
Expand Down Expand Up @@ -22322,21 +22312,6 @@ attribute.</p>
for the <loc
href="#style-attribute-textOrientation"><att>tts:textOrientation</att></loc>
attribute.</p>
<p>Notwithstanding the above, support for the <code>#textOrientation</code> feature does not require support for the
<loc href="#feature-textOrientation-sideways-LR"><code>#textOrientation-sideways-LR</code></loc> feature.</p>
</div3>
<div3 id="feature-textOrientation-sideways-LR">
<head>#textOrientation-sideways-LR</head>
<p>A TTML <loc href="#terms-transformation-processor">transformation processor</loc> supports the
<code>#textOrientation-sideways-LR</code> feature if it recognizes and is capable of
transforming the <code>sidewaysLeft</code> and <code>sidewaysRight</code> values of the <loc
href="#style-attribute-textOrientation"><att>tts:textOrientation</att></loc>
attribute.</p>
<p>A TTML <loc href="#terms-presentation-processor">presentation processor</loc> supports the
<code>#textOrientation-sideways-LR</code> feature if it implements presentation semantic support
for the <code>sidewaysLeft</code> and <code>sidewaysRight</code> values of the <loc
href="#style-attribute-textOrientation"><att>tts:textOrientation</att></loc>
attribute.</p>
</div3>
<div3 id="feature-textOutline">
<head>#textOutline</head>
Expand Down Expand Up @@ -23986,12 +23961,6 @@ is optional (O), for a TTML <loc href="#terms-content-processor">content process
<td css="text-align:center;">O</td>
</tr>
<tr>
<td><loc href="#feature-textOrientation-sideways-LR"><code>#textOrientation-sideways-LR</code></loc></td>
<td css="text-align:center;">2</td>
<td css="text-align:center;">O</td>
<td css="text-align:center;">O</td>
</tr>
<tr>
<td><loc href="#feature-textOutline"><code>#textOutline</code></loc></td>
<td css="text-align:center;">1</td>
<td css="text-align:center;">O</td>
Expand Down
2 changes: 0 additions & 2 deletions spec/xsd/ttml2-datatypes.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,8 +669,6 @@
<xs:restriction base="xs:token">
<xs:enumeration value="mixed"/>
<xs:enumeration value="sideways"/>
<xs:enumeration value="sidewaysLeft"/>
<xs:enumeration value="sidewaysRight"/>
<xs:enumeration value="upright"/>
</xs:restriction>
</xs:simpleType>
Expand Down