Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a definition of contextmenu event. #316

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Conversation

mustaqahmed
Copy link
Member

@mustaqahmed mustaqahmed commented Oct 5, 2021

Closes #279

The following tasks have been completed:

  • Confirmed there are no ReSpec/BikeShed errors or warnings.
  • Modified Web platform tests (link to pull request)

Implementation commitment:

All major browsers already fire contextmenu event. The "commitments" below really indicate the "already-shipped" status, so bug links are irrelevant. Here is a test page.

  • WebKit
  • Chromium
  • Gecko

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 6, 2021
This is related to: w3c/uievents#316

Change-Id: I2831657c32bd98ca76773129bef4f09b04bdb3ac
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 7, 2021
This is related to: w3c/uievents#316

Change-Id: I2831657c32bd98ca76773129bef4f09b04bdb3ac
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 7, 2021
This is related to: w3c/uievents#316

Change-Id: I2831657c32bd98ca76773129bef4f09b04bdb3ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3208193
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#929222}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 7, 2021
This is related to: w3c/uievents#316

Change-Id: I2831657c32bd98ca76773129bef4f09b04bdb3ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3208193
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#929222}
pull bot pushed a commit to Alan-love/chromium that referenced this pull request Oct 7, 2021
This is related to: w3c/uievents#316

Change-Id: I2831657c32bd98ca76773129bef4f09b04bdb3ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3208193
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#929222}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Oct 14, 2021
….r.t mouse events., a=testonly

Automatic update from web-platform-tests
Add a test for contextmenu event order w.r.t mouse events.

This is related to: w3c/uievents#316

Change-Id: I2831657c32bd98ca76773129bef4f09b04bdb3ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3208193
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#929222}

--

wpt-commits: 393d88d184b7981a9ebcaf49dd38dd253a1f2534
wpt-pr: 31138
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Oct 14, 2021
….r.t mouse events., a=testonly

Automatic update from web-platform-tests
Add a test for contextmenu event order w.r.t mouse events.

This is related to: w3c/uievents#316

Change-Id: I2831657c32bd98ca76773129bef4f09b04bdb3ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3208193
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#929222}

--

wpt-commits: 393d88d184b7981a9ebcaf49dd38dd253a1f2534
wpt-pr: 31138
@mustaqahmed mustaqahmed merged commit 6753ebf into w3c:main Oct 15, 2021
github-actions bot added a commit that referenced this pull request Oct 15, 2021
SHA: 6753ebf
Reason: push, by @mustaqahmed

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Gabisampaio pushed a commit to Gabisampaio/wpt that referenced this pull request Nov 18, 2021
This is related to: w3c/uievents#316

Change-Id: I2831657c32bd98ca76773129bef4f09b04bdb3ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3208193
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#929222}
dontcallmedom pushed a commit to dontcallmedom/uievents that referenced this pull request Jul 1, 2022
SHA: 6753ebf
Reason: push, by @mustaqahmed

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
This is related to: w3c/uievents#316

Change-Id: I2831657c32bd98ca76773129bef4f09b04bdb3ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3208193
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#929222}
NOKEYCHECK=True
GitOrigin-RevId: 59e1a1e7d235c4ec928baaff82edf06af0343f90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We don't have a definition for "contextmenu" event
2 participants