-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Internationalization Considerations section. #111
Conversation
index.html
Outdated
@@ -2487,5 +2487,33 @@ <h3>Selective Disclosure</h3> | |||
|
|||
</section> | |||
|
|||
<section> | |||
<h2>Internationalization Considerations</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The I18N WG generally does not request the creation of "Internationalization Considerations" sections unless there is a really specific message that needs to be communicated. We generally prefer that linguistic, cultural, regional, and other considerations be dealt with in the section(s) that are applicable (and where guidance will most likely be seen by implementers).
I would be much happier if you put a note block into the "representing time" section (the original one linked to but the new "representing time" sub-section in this PR) that says something like:
<!-- note this links to a term in the i18n-glossary -->
<div class="note">
<p>When displaying date and time values related to the
validity of cryptographic proofs, implementers should
respect the <a>locale</a> and possibly local calendar
preferences of the user.
Conversion of timestamps to local time values should
consider the time zone expectations of the user.</p>
</div>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we could just put your recommended text alongside the created parameter in the Proofs (section 2.1) which is the only place we have a date/time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Wind4Greg exactly so.
Note that I18N in in the process of doing a review and there is a pending
issue related to this (with different textual recommendations in it) here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aphillips we'll want to be consistent with the VC Data Model 2.0 and I particularly like your point about handling cases with/without timezone information!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll make the change as you suggest @aphillips -- thank you. I'll also try to cross-link to the vc-data-model section on time representation so we take advantage of the text over there as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in bae11c6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 and happy for this to be reconfigured in the way @aphillips suggested.
508ecd6
to
bae11c6
Compare
Editorial, multiple reviews, changes requested and made, no objections, merging. |
This PR adds an internationalization considerations section, even though the spec is largely a cryptographic enveloping mechanism (and thus doesn't interact with individuals directly). There is one consideration related to date/time values that was worth mentioning, so that's been added.
Preview | Diff