Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add revoked definition and anchor for vocabulary. #154

Merged
merged 2 commits into from
Aug 12, 2023
Merged

Add revoked definition and anchor for vocabulary. #154

merged 2 commits into from
Aug 12, 2023

Conversation

msporny
Copy link
Member

@msporny msporny commented Aug 6, 2023 •
edited by pr-preview bot
Loading

This PR partially addresses issue #129 by adding a definition and anchor for the revoked property.

Preview | Diff

@msporny msporny changed the base branch from msporny-add-proof-dfn to msporny-define-secret-key August 6, 2023 18:19
@msporny msporny mentioned this pull request Aug 6, 2023
Closed
iherman
iherman approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in another PR: it might be the quickest to add this reference to the relevant vocabulary item and remove the comment altogether, to speed up the PR cycles...

TallTed
TallTed suggested changes Aug 7, 2023
View reviewed changes
index.html Outdated Show resolved Hide resolved
@iherman iherman mentioned this pull request Aug 8, 2023
Merged
An error occurred while trying to automatically change base from msporny-define-secret-key to msporny-json-web-key August 12, 2023 19:29
@msporny msporny changed the base branch from msporny-define-secret-key to main August 12, 2023 19:49
@msporny @TallTed
Specify when revoked keys should cease to be used.
fca95c0 
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@msporny
Copy link
Member Author

msporny commented Aug 12, 2023

Normative, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit 7fa7bb5 into main Aug 12, 2023
1 check passed
@msporny msporny deleted the msporny-add-revoked branch August 12, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallTed TallTed TallTed requested changes

@dlongley dlongley dlongley approved these changes

@iherman iherman iherman approved these changes

@dmitrizagidulin dmitrizagidulin dmitrizagidulin approved these changes

@Wind4Greg Wind4Greg Wind4Greg approved these changes

@seabass-labrax seabass-labrax Awaiting requested review from seabass-labrax

@davidlehn davidlehn Awaiting requested review from davidlehn

@brentzundel brentzundel Awaiting requested review from brentzundel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@msporny @dlongley @iherman @dmitrizagidulin @Wind4Greg @TallTed