-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test text to match spec. #81
Conversation
Same tests, though.
No tests were changed. Just MUST statements, links, and whitespace.
We are only testing MUSTs for the moment.
No longer included in the VCDMv2 text (most likely moved to Data Integrity spec).
Update language to match spec.
Reword one test in the Refreshing subsection.
The `id` is no longer required.
They no longer have MUST grade statements in the spec.
These were also not in the spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing apparently accidentally-dropped periods.
Thanks, @TallTed! Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as it adds the text, but not necessarily the test. good PR to move forward from and thanks for the work. Do what you want with that editorConfig file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the changes, I have a few more inconsistencies to add as well from my fork. Once this is merged in I'll pull these changes and open my PR
Per the upcoming merge of w3c/vc-data-model#1530 Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Pulled up from where these are additionally tests. Only added reject tests.
Just going to put it right back...but robots... >_<
...which caused an astounding amount of whitespace shifting for one word to be added... >_<
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving again provided this PR is checked to ensure commits in it are not duplicates of existing commits in main (might need a rebase from main in other words).
Addressed the issues per your request. Thanks! Pushing this along given time constraints (and that fact that despite the robot opinion the issues were addressed).
This includes minimal test changes. Some assert error messages were added and a
couple test fixtures where removed since they are no longer needed).
Details below:
proof
type tests.