Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test text to match spec. #81

Merged
merged 34 commits into from
Jul 15, 2024
Merged

Update test text to match spec. #81

merged 34 commits into from
Jul 15, 2024

Conversation

BigBlueHat
Copy link
Member

This includes minimal test changes. Some assert error messages were added and a
couple test fixtures where removed since they are no longer needed).

Details below:

  • Update @context test to use ordered set language.
  • Use a single MUST statement for IDs.
  • Rename credential ID fixtures for easy findling.
  • Remove duplicate fixture/test post consolidation.
  • Update requirements text in Types section.
  • Remove skipped SHOULD statement.
  • Remove proof type tests.
  • Add failure messages to some rejections.
  • Add TODOs for Conformance section.
  • Extract Verifiable Presentations section.
  • Update existing VP test to use new text.
  • Add pending test for VP id field.
  • Add VP type pending test.
  • Add pending tests for Enveloped VCs.
  • Add VP holder claims pending tests.
  • Create sections for subsections of VP tests.
  • Move Data Schemas tests up from Advanced.
  • Add some assert messages to help debugging.
  • Begin updating Advanced section.
  • Remove id tests in Refreshing.
  • Unskip Refreshing tests.
  • Add links to Refreshing section.
  • Add links to termsOfUse tests.
  • Add link and note to Evidence test.
  • Remove skipped ZKP tests.
  • Remove remaining two skipped tests.
  • Add comments for possible future tests.
  • Add .editorconfig.

@BigBlueHat
Update @context test to use ordered set language.
0aa6f76
@BigBlueHat
Use a single MUST statement for IDs.
3173033 
Same tests, though.
@BigBlueHat
Rename credential ID fixtures for easy findling.
b2eda3e
@BigBlueHat
Remove duplicate fixture/test post consolidation.
47b33e3
@BigBlueHat
Update requirements text in Types section.
9cbf4c5 
No tests were changed. Just MUST statements, links, and whitespace.
@BigBlueHat
Remove skipped SHOULD statement.
a407cea 
We are only testing MUSTs for the moment.
@BigBlueHat
Remove proof type tests.
c17c2f6 
No longer included in the VCDMv2 text (most likely moved to
Data Integrity spec).
@BigBlueHat
Add failure messages to some rejections.
521ac39
@BigBlueHat
Add TODOs for Conformance section.
367d63e
@BigBlueHat
Extract Verifiable Presentations section.
0825711
@BigBlueHat
Update existing VP test to use new text.
8fcfe6f
@BigBlueHat
Add pending test for VP id field.
e4df7e0
@BigBlueHat
Add VP type pending test.
eb832fe
@BigBlueHat
Add pending tests for Enveloped VCs.
381654e
@BigBlueHat
Add VP holder claims pending tests.
01aabf6
@BigBlueHat
Create sections for subsections of VP tests.
5110f1f
@BigBlueHat
Move Data Schemas tests up from Advanced.
338d44a 
Update language to match spec.
@BigBlueHat
Add some assert messages to help debugging.
db549a9
@BigBlueHat
Begin updating Advanced section.
d749202 
Reword one test in the Refreshing subsection.
@BigBlueHat
Remove id tests in Refreshing.
eb0477f 
The `id` is no longer required.
@BigBlueHat
Unskip Refreshing tests.
2871234
@BigBlueHat
Add links to Refreshing section.
9afd901
@BigBlueHat
Add links to termsOfUse tests.
6c2bae7
@BigBlueHat
Add link and note to Evidence test.
a668a7a
@BigBlueHat
Remove skipped ZKP tests.
d3ec2c0 
They no longer have MUST grade statements in the spec.
@BigBlueHat
Remove remaining two skipped tests.
5eadec2 
These were also not in the spec.
@BigBlueHat
Add comments for possible future tests.
3ed7970
@BigBlueHat
Add .editorconfig.
8c25a54
TallTed
TallTed previously requested changes Jul 11, 2024
View reviewed changes
Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing apparently accidentally-dropped periods.

tests/10-vcdm2.js Outdated Show resolved Hide resolved
tests/10-vcdm2.js Outdated Show resolved Hide resolved
tests/10-vcdm2.js Outdated Show resolved Hide resolved
BigBlueHat and others added 2 commits July 12, 2024 10:49
@BigBlueHat @TallTed
Add missing periods.
70db5ed 
Thanks, @TallTed!

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@BigBlueHat
Remove unused vas from Status section.
5f10c0f
@BigBlueHat BigBlueHat requested a review from TallTed July 12, 2024 14:52
aljones15
aljones15 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@aljones15 aljones15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as it adds the text, but not necessarily the test. good PR to move forward from and thanks for the work. Do what you want with that editorConfig file.

tests/10-vcdm2.js Outdated Show resolved Hide resolved
tests/10-vcdm2.js Show resolved Hide resolved
tests/10-vcdm2.js Show resolved Hide resolved
PatStLouis
PatStLouis approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@PatStLouis PatStLouis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the changes, I have a few more inconsistencies to add as well from my fork. Once this is merged in I'll pull these changes and open my PR

tests/10-vcdm2.js Outdated Show resolved Hide resolved
@BigBlueHat @TallTed
Add refershService & credentialSchema to type musts.
9f894f2 
Per the upcoming merge of w3c/vc-data-model#1530

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@BigBlueHat
Add refershService & credentialSchema type tests.
014b83a 
Pulled up from where these are additionally tests.
Only added reject tests.
@BigBlueHat
Remove unused variables to keep linter happy.
9d33000 
Just going to put it right back...but robots... >_<
@BigBlueHat
Add which field is being tested in order test.
41f2a0f 
...which caused an astounding amount of whitespace shifting for one
word to be added... >_<
PatStLouis
PatStLouis approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@PatStLouis PatStLouis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

aljones15
aljones15 approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@aljones15 aljones15 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving again provided this PR is checked to ensure commits in it are not duplicates of existing commits in main (might need a rebase from main in other words).

@BigBlueHat BigBlueHat dismissed TallTed’s stale review July 15, 2024 19:23

Addressed the issues per your request. Thanks! Pushing this along given time constraints (and that fact that despite the robot opinion the issues were addressed).

@BigBlueHat BigBlueHat merged commit db10bfd into main Jul 15, 2024
2 checks passed
@BigBlueHat BigBlueHat deleted the quote-updates branch July 15, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aljones15 aljones15 aljones15 approved these changes

@PatStLouis PatStLouis PatStLouis approved these changes

@tminard tminard Awaiting requested review from tminard

@TallTed TallTed Awaiting requested review from TallTed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BigBlueHat @aljones15 @TallTed @PatStLouis