Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the domain statement of "holder" #1078

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Conversation

iherman
Copy link
Member

@iherman iherman commented Apr 5, 2023

Remove the VerifiableCredential from the possible domains of holder. This is the "execution" of #1076 (comment).

Beware! This is a PR against the OR13-remove-holder-from-vc PR, not against the main branch!

OR13 and others added 2 commits April 4, 2023 10:52
Remove the VerifiableCredential from the possible domains of holder. This is the "execution" of #1076 (comment).

Beware! This is a PR against the OR13-remove-holder-from-vc PR, not against the main branch!
Copy link
Contributor

@awoie awoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from OR13-remove-holder-from-vc to main April 10, 2023 22:03
@msporny
Copy link
Member

msporny commented Apr 10, 2023

Substantive, multiple reviews, changes requested (in another PR and made in this PR), no objections, merging.

@msporny msporny merged commit 42ceab2 into main Apr 10, 2023
@msporny msporny deleted the iherman-change-holder-domain branch April 10, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants