Clarify proof section #1106
Merged
Clarify proof section #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
brentzundel
requested review from
msporny,
OR13,
selfissued,
decentralgabe and
awoie
as code owners
selfissued
approved these changes
Apr 28, 2023
msporny
approved these changes
Apr 28, 2023
TallTed
requested changes
Apr 28, 2023
TallTed
approved these changes
May 1, 2023
msporny
reviewed
May 4, 2023
Comment on lines
+1731
to
+1732
| Methods of securing <a>credentials</a> or <a>presentations</a> that embed a | ||
| proof in the data model MUST use the <code>proof</code> <a>property</a>. |
There was a problem hiding this comment.
I'm just noting a bit of concern on this item. I think it's a good call for v2.0 as long as future major revisions allow for possibly other fooProof properties that also secure the data model (in the event that proof is not flexible enough. I highly doubt that proof wouldn't be flexible enough, but just thought it worth mentioning before merging this PR. We don't want to block other embedded proofing mechanisms (forever) from existing and being used for VCs.
|
Normative, multiple reviews, changes requested and made, no objections, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes minor normative changes to the proof section.
It renames the section to indicate that the focus is on Securing VCs.
It rewords the introduction to focus on securing rather than proofs.
It clarifies the normative possibilities around the proof property to better reflect the way it is actually used.
fixes #1104
Preview | Diff