Add language clarifying VP is short-lived #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
brentzundel
requested review from
msporny,
OR13,
selfissued,
decentralgabe and
awoie
as code owners
msporny
approved these changes
Jun 21, 2023
decentralgabe
approved these changes
Jun 21, 2023
andresuribe87
approved these changes
Jun 21, 2023
awoie
reviewed
Jun 22, 2023
awoie
approved these changes
Jun 22, 2023
OR13
reviewed
Jun 23, 2023
index.html
Outdated
| @@ -1917,7 +1917,12 @@ <h3>Presentations</h3> | |||
| <a>verifiable credentials</a> is a typical use of | |||
| <a>verifiable presentations</a>. | |||
| </p> | |||
|
|
|||
| <p> | |||
| <a>Verifiable presentations</a> are intended to be extremely short-lived, and | |||
There was a problem hiding this comment.
This does not seem to align with the normative requirements we have in the spec.
There was a problem hiding this comment.
I don't think this is a good change - see my post. Also, no example has been provided why VPs are intended to be (extremely) short lived, as suggested by @Sakurann s comment. So, lacking any substantiation for the assertion that presentations are intended to be extremely short-lived, and noting that the standard cannot know the intentions of holders regarding the presentations they create,I suggest to not merge this.
OR13
reviewed
Jun 23, 2023
OR13
suggested changes
Jun 23, 2023
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Orie Steele <orie@or13.io>
brentzundel
commented
Jun 23, 2023
brentzundel
commented
Jun 23, 2023
TallTed
approved these changes
Jun 23, 2023
dlongley
approved these changes
Jun 25, 2023
OR13
approved these changes
Jun 26, 2023
|
Normative, multiple reviews, changes requested and made, no objections, merging. |
This was referenced Jun 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #937
This PR uses language suggested in #937 to clarify that VPs are intended to be short-lived.
Preview | Diff