Move section on code injection to security considerations. #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msporny
requested review from
aphillips,
shigeya,
dlongley,
jandrieu,
iherman,
dmitrizagidulin,
andresuribe87,
TallTed,
David-Chadwick,
simoneonofri,
decentralgabe,
brentzundel and
KDean-GS1
msporny
added
editorial
aphillips
approved these changes
Mar 23, 2024
iherman
approved these changes
Mar 24, 2024
dlongley
approved these changes
Mar 24, 2024
decentralgabe
approved these changes
Mar 25, 2024
brentzundel
approved these changes
Mar 25, 2024
TallTed
requested changes
Mar 26, 2024
longpd
approved these changes
Mar 27, 2024
|
The issue was discussed in a meeting on 2024-03-27
View the transcript3.4. Section title and contents mismatch on "Complex Language Markup" (issue vc-data-model#1254)See github issue vc-data-model#1254. See github pull request vc-data-model#1463. Brent Zundel: this PR can be merged by the end of this week. |
David-Chadwick
approved these changes
Mar 29, 2024
shigeya
approved these changes
Apr 1, 2024
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com> Co-authored-by: David Chadwick <d.w.chadwick@verifiablecredentials.info>
|
Editorial, multiple reviews, changes requested and made, no objections, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address issue #1254 by moving the "Complex Markup" section into the "Security Considerations" section and warning about code injection attacks.
Preview | Diff