-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accessibility note #235
Conversation
Signed-off-by: Daniel Hardman <daniel.hardman@gmail.com>
Signed-off-by: Daniel Hardman <daniel.hardman@gmail.com>
Signed-off-by: Daniel Hardman <daniel.hardman@gmail.com>
Signed-off-by: Daniel Hardman <daniel.hardman@gmail.com>
I read the issue differently. Common feedback for specifications is to make sure that images used within the spec have a description. Note how we handled this in json-ld11. <figure id="fig-linked-data-graph" style="text-align:center">
<!-- Source for this file is at https://docs.google.com/drawings/d/1_bRm1d9hTTqAqv5q8KEBzI47HxAUrbceA0EE5APh8hA/edit?usp=sharing -->
<object data="linked-data-graph.svg" style="width: 75%" type="image/svg+xml" aria-describedby="fig-linked-data-graph-alt">
<p id="fig-linked-data-graph-alt">The image depicts a linked data dataset with a default graph
and two named graphs.</p>
</object>
<figcaption>An illustration of a linked data dataset.<br/>
A <a href="#fig-linked-data-graph-descr">description of the linked data dataset
diagram</a> is available in the Appendix. Image available in
<a href="linked-data-graph.svg" title="SVG image of a linked data dataset">
<abbr title="Scalable Vector Graphics">SVG</abbr>
</a> and
<a title="PNG image of a linked data dataset" href="linked-data-graph.png">
<abbr title="Portable Network Graphics">PNG</abbr>
</a>
formats.</figcaption>
</figure> Note that there is also a reference to an appendix with more detailed descriptions. This is what I understand Janina to be requesting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it doesn't address the original spec a11y issue, there is text in here that we want to pull into the spec.
of verification, the revocation mechanism to use etc. | ||
of verification, the revocation mechanism to use, etc. | ||
(Where images are used, it is recommended to consider accessibility | ||
issues as described in <a href="https://www.w3.org/WAI/tutorials/images/complex/">W3C |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @gkellogg, this isn't what Janina and the Accessibility folks were requesting (they wanted descriptions of the images used in the W3C VC specification), so suggest that we strike it (but keep the rest of the PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhh1128 is raising a good concern related to expressing VCs that contain images to people with Accessibility needs. I'm not certain we have enough experience to say much at this point other than something to this effect: "If you use images, you're making future Accessibility concerns more difficult... stick to just expressing pure data in VCs so that systems can choose how to render the VC appropriately (e.g. audio, braille, high contrast graphics, vibrations, etc.)."
@@ -2478,13 +2481,14 @@ <h3>The Principle of Minimum Disclosure</h3> | |||
attribute that appears on a driver's license in addition to atomized | |||
credentials (a credential containing only the person's birthday), and atomized | |||
credentials that are more abstract (a credential containing only an | |||
<code>ageOver</code> attribute). In addition, the issuer is encouraged to | |||
<code>ageOver</code> attribute). One possible simple adaptation is for the issuer to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep this change and the one below...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now in the spec.
I totally dropped the ball on this. I was supposed to write an accessibility note, which is more far-reaching than including image descriptions. I will get to this before the end of September. |
Not a request to change this PR, but I thought this advance topic paper from the upcoming #RebootingWebOfTrust on “Verifiable Displays” https://github.com/WebOfTrustInfo/rwot7/blob/master/topics-and-advance-readings/verifiable_displays.md may be relevant for future discussions. “This emphasis on machine verification is essential, but what's not in scope of the VC Data Model is scenarios where a human participates in verification. In the Educational/Occupational space, suppose a recipient has received an academic credential that they want to share with a potential employer. The potential employer can cryptographically verify the content, but the employer is typically not looking at the raw json content of the credential; instead they are looking at an image, PDF, or some friendlier visual representation. The question arises: how does the employer know that the friendly display they see is what the issuer intended? In general, how do they know the display matches the content? This is currently addressed in a variety of (sometimes incomplete) ways. This paper surveys existing solutions to the problem, and develops a set of requirements based on lessons learned. This proposes a general solution based on the authors' experiences developing Blockcerts and Validbook.” |
This addresses the feedback in issue #225 . There is only one reference to images in the spec, so I placed the text there despite the somewhat awkward flow.
Preview | Diff