Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create SECURITY.md #854

Closed
wants to merge 1 commit into from
Closed

Conversation

pavelkorablev6
Copy link

w3c:v1.1

Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a generic SECURITY.md file is probably not helpful at this point in time. This is something that other W3C specifications don't do, AFAIK.

There are only two versions of VCs (1.0 and 1.1), and both are supported at present, AFAIK. Reporting a vulnerability is a good thing to have, but it's noted in the specification (raise an issue).

Largely, -1 to this PR because it's generic and having multiple places w/ the same information can be problematic as the Editors will forget to update all the places over time.

@kdenhartog
Copy link
Member

-1 from me as well. If the specification itself has an issue it should be raised as an issue and addressed via proper discussions rather than a limited number of people finding out about it IMO. These security documents are more useful for implementations I'd think.

Copy link
Member

@kdenhartog kdenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the WG does decide this is needed (-1 from me and the other editor so far) then the text needs to be updated to be more specific than the generic text included at the moment.

@TallTed
Copy link
Member

TallTed commented Dec 28, 2021

@pavelkorablev6 -- Different people will approach this project and its information in different ways. SECURITY.md appears to be a GitHub-minded semi-de-facto standard place for such information, but please note that it is not a W3-minded place for this.

Might I suggest, therefore, that @pavelkorablev6 modify the SECURITY.md content in this PR to suit this W3 project? That is, change the boilerplate, which really says nothing right now, to link to the relevant section of the published Data Model document and the Data Model issues page.

Given those changes, I would think that adding a reciprocal comment to the HTML source of the Data Model document, which points to this SECURITY.md, would be sufficient to remind editors to update the latter if the hrefs it targets are changed for whatever unlikely reason. Maybe an additional check in the GitHub Actions could flag any errors which might result from SECURITY.md hrefs targeting URLs which no longer exist?

@msporny
Copy link
Member

msporny commented Dec 28, 2021

@TallTed wrote:

Given those changes, I would think that adding a reciprocal comment to the HTML source of the Data Model document, which points to this SECURITY.md, would be sufficient to remind editors to update the latter if the hrefs it targets are changed for whatever unlikely reason.

I'm afraid that I would almost certainly miss that pointer in the HTML source. It's exceedingly easy to miss content like that, which is why we tend to prefer content in one location to make sure we don't screw things up over time. Working memory fades rapidly, and SECURITY.md is not a part of many Editor's workflows at W3C, so unless we can automate this (and we have bigger fish to fry here), I suggest we just drop it entirely. The place for this information is in the Status of the Document section and the README.md file. Almost all of the thousands of W3C repos don't use SECURITY.md to my knowledge.

I appreciate that we're trying to find a way to pull in @pavelkorablev6's PR, but in this instance, I think it does more harm than good.

That said, I wouldn't be averse to putting this information in README.md, but what that should really do is just duplicate the Status of the Document section verbatim... which tells people how to engage w/ issues/PRs/etc.

@TallTed
Copy link
Member

TallTed commented Dec 28, 2021

That said, I wouldn't be averse to putting this information in README.md, but what that should really do is just duplicate the Status of the Document section verbatim... which tells people how to engage w/ issues/PRs/etc.

That seems a reasonable solution, given which I wouldn't mind also having SECURITY.md reduced to a pointer to README.md.

@msporny msporny added the pending close Close if no objection within 7 days label Jan 30, 2022
@msporny
Copy link
Member

msporny commented Jan 30, 2022

Marking this PR as "close after 7 days". The individual that raised the PR is non-responsive and it does not look like this PR is going to be accepted in it's current form. This PR will be closed after February 6th 2022.

@kdenhartog
Copy link
Member

closing this PR - it's been 10 days since the label was added.

@kdenhartog kdenhartog closed this Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending close Close if no objection within 7 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants