Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Linked Data Proofs" to "Data Integrity". #859

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

peacekeeper
Copy link
Contributor

@peacekeeper peacekeeper commented Jan 11, 2022

This updates the name and link for the Data Integrity draft specification that was previously called "Linked Data Proofs", and is mentioned in the proposed Verifiable Credentials Working Group Charter. This may not yet be the final name of that specification.

Fixes #858.


Preview | Diff

Copy link
Member

@kdenhartog kdenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kdenhartog kdenhartog added editorial Purely editorial changes to the specification. merge after 14 days v1.1 (editorial) errata Erratum for a W3C Recommendation and removed editorial Purely editorial changes to the specification. errata Erratum for a W3C Recommendation labels Jan 11, 2022
@iherman
Copy link
Member

iherman commented Jan 14, 2022

The issue was discussed in a meeting on 2022-01-12

  • no resolutions were taken
View the transcript

4.2. Rename "Linked Data Proofs" to "Data Integrity". (pr vc-data-model#859)

See github pull request vc-data-model#859.

Manu Sporny: Renaming LD Proofs to Data Integrity, by Markus.
… I haven't approved it yet, looks like it does what it says, looks good to me.
… It's a change we've made across the board.
… Anyone on the call concerned with this?.
… We had just 1 day period on this PR...

Brent Zundel: I think we need a resolution what we will merge next week.

Manu Sporny: This will go in.

@nikosft
Copy link

nikosft commented Jan 18, 2022

This pull request still uses "Linked Data Proofs" for the title of section 6.3.2. Moreover, this section says

The Linked Data Proofs format was designed to simply and easily protect
<a>verifiable credentials</a> and <a>verifiable presentations</a>. Protecting
a <a>verifiable credential</a> or <a>verifiable presentation</a> is as simple
as passing a valid example in this specification to a Linked Data Signatures
implementation and generating a digital signature.

I think using at the same time Linked Data Proofs, Linked Data Signatures, and Data integrity will create confusion.

@peacekeeper
Copy link
Contributor Author

@nikosft thanks for pointing that out. I added one more commit which I think renames those additional occurrences I missed previously.

@kdenhartog
Copy link
Member

No objections noted and requests have been addressed by the author. Multiple positive reviews and the 14 day period has lapsed. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Referenced ld-proofs : https://w3c-ccg.github.io/ld-proofs/
7 participants