Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update proofConfig.type & cryptosuite test title & expand vectors. #47

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Update proofConfig.type & cryptosuite test title & expand vectors. #47

merged 1 commit into from
Jul 3, 2024

Conversation

aljones15
Copy link
Collaborator

@aljones15 aljones15 commented Jul 2, 2024 •
edited

  1. updates the title and link to match latest spec
  2. expands the test vectors to cover all 3 negative cases

@aljones15 aljones15 self-assigned this Jul 2, 2024
@aljones15 aljones15 marked this pull request as ready for review July 2, 2024 13:50
@TallTed
Copy link
Member

TallTed commented Jul 2, 2024

vectors 2 cover

For a variety of reasons, I recommend against using such abbreviations and shortcuts, even in commit notes.

The English looks good. I cannot judge the JavaScript.

@aljones15 aljones15 requested a review from Wind4Greg July 2, 2024 21:00
@aljones15 aljones15 merged commit 9469f70 into main Jul 3, 2024
2 checks passed
@aljones15 aljones15 deleted the update-title-proofConfig.type branch July 3, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wind4Greg Wind4Greg Wind4Greg approved these changes

@BigBlueHat BigBlueHat Awaiting requested review from BigBlueHat

@TallTed TallTed Awaiting requested review from TallTed

Assignees

@aljones15 aljones15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aljones15 @TallTed @Wind4Greg