Update all text to specify the SHA-256 hash function rather than SHAKE-256 #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wind4Greg
requested review from
msporny,
dlongley,
brianorwhatever,
decentralgabe and
brentzundel
dlongley
approved these changes
Jan 13, 2024
msporny
approved these changes
Feb 2, 2024
TallTed
suggested changes
Feb 2, 2024
…-256: wording and punctuation improvements. Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
|
Probably better to resolve merge conflicts before I re-review |
Ready for you to re-review @TallTed |
TallTed
approved these changes
Feb 9, 2024
|
Normative multiple reviews, no changes requested, no objections, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #118 on switching to using the SHA-256 variant of BBS, using SHA-256 for hashes, and using SHA-256 for HMAC computations.
This PR does not update the test vectors. They will be updated in a separate PR.
Preview | Diff