Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Proof Configuration Procedure to Pass Through Proof options #141

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

Wind4Greg
Copy link
Collaborator

@Wind4Greg Wind4Greg commented Feb 29, 2024

This PR addresses issue #139 to bring this specification in line with the VC-DI-ECDSA specification on the pass through of additional options during proof configuration.


Preview | Diff

Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems some other changes might have snuck in here from another PR/branch -- but +1 to the proof config algorithm changes here.

@Wind4Greg Wind4Greg requested a review from msporny March 3, 2024 21:41
@msporny
Copy link
Member

msporny commented Mar 7, 2024

Normative, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit e8e1ba3 into w3c:main Mar 7, 2024
2 checks passed
@Wind4Greg Wind4Greg deleted the proof-options branch April 9, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants