-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all Multicodec / Multibase references non-normative. #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR doesn't do the job. The point of the issue was to remove the references - not to make them non-normative. Making them non-normative means that required fields are undefined, which is unacceptable for a standard.
Instead, remove the references to multibase and add normative text fully defining the contents of the fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment in w3c/vc-di-eddsa#63; it is verbatim relevant for this PR, too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small stuff
My original review comment is moot, in view of w3c/vc-data-integrity#196 (comment). Changing the review. |
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
b0410b8
to
b6aa1a8
Compare
@selfissued there are now no references to the IETF I-Ds on Multiformats, we instead either normatively define the values needed in the spec, or refer back to VC Data Integrity, which defines the values needed. Requesting re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This spec is still referencing ?MULTIBASE rather than normative definitions of the features used.
Many of the comments in w3c/vc-di-eddsa#63 (review) and w3c/vc-data-integrity#196 (review) also apply to this specification.
In particular, the referenced terms need be normatively defined in sufficient detail to enable interoperable implementations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this resolves all the concerns that were brought up in this week's VCWG meeting.
Sorry, there was code stuck on my local copy that removed all those references, requesting another re-review from you. |
@selfissued re-ping to re-review... ideally, you approve before we merge this. It's all green on reviews so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this.
The issue was discussed in a meeting on 2023-10-11
View the transcript1.3. Make all Multicodec / Multibase references non-normative. (pr vc-di-ecdsa#42)See github pull request vc-di-ecdsa#42. Manu Sporny: I see he's approved the last remaining well as well. Brent Zundel: There are a lot of VCDM PRs. |
Normative, multiple reviews, changes requested and made, no objections, merging. |
This PR attempts to address issue #39 by making all Multicodec / Multibase references non-normative and cites the normative sections of PR w3c/vc-data-integrity#196 as requested by the issue submitter.
Preview | Diff