-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates tag names required to run the test suite. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSAssassin
changed the title
Use latest
Use latest Nov 16, 2023
vc-test-suite-implementations
repo and change test suite tag names.vc-test-suite-implementations
package and change test suite tag names.
JSAssassin
force-pushed
the
use-latest-implementations
branch
from
November 16, 2023 20:20
9568326
to
7a66f2b
Compare
JSAssassin
changed the title
Use latest
Updates tag names required to run the test suite.
Nov 16, 2023
vc-test-suite-implementations
package and change test suite tag names.
JSAssassin
requested review from
BigBlueHat,
msporny,
dlongley and
aljones15
November 16, 2023 20:25
JSAssassin
force-pushed
the
use-latest-implementations
branch
from
November 16, 2023 22:29
7a66f2b
to
b5dad6e
Compare
dlongley
approved these changes
Nov 19, 2023
BigBlueHat
approved these changes
Nov 20, 2023
TallTed
requested changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny. Plural noun takes plural verb.
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
aljones15
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TallTed
approved these changes
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vc-test-suite-implementations
package.Test Result: