-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix byte length of publickKeyMultibase
.
#67
Conversation
iherman marked as non substantive for IPR from ash-nazg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it seems that the description is also bit problematic. The publicKeyMultibase
value is a string that contains the base-58-btc encoding of the 2 byte prefix plus the 32 byte key. So the length in bytes of what is being encoded is 34 bytes but the string size is whatever. Shouldn't we re-write this a little to be clearer.
Yes, I'll do some editorial fix-ups to make this more clear after the merge. I can't edit the PR, so I have to do the fixes in a separate commit. UPDATE: This is now complete in commit 215cdba |
Arguably normative, multiple reviews, changes requested (and will be made in a separate commit), no objections, merging. |
Addresses #66
Preview | Diff