Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix B.3 Representation: Ed25519Signature2020 test vectors #76

Merged
merged 5 commits into from
Mar 3, 2024

Conversation

filip26
Copy link
Contributor

@filip26 filip26 commented Feb 16, 2024

Adds missing @context https://w3id.org/security/suites/ed25519-2020/v1 to Ed25519Signature2020 test vectors. Proof canonical form, hash, and signature are re-computed.

It's related to, but does not close, issue #75


Preview | Diff

@w3cbot
Copy link

w3cbot commented Feb 16, 2024

iherman marked as non substantive for IPR from ash-nazg.

@msporny
Copy link
Member

msporny commented Feb 25, 2024

@filip26, thanks for the PR -- do you know if these updates align w/ other implementations (I imagine they do since you're passing the test suite?)

@Wind4Greg, what's going on with these test vectors? Are these updates correct?

@filip26
Copy link
Contributor Author

filip26 commented Feb 26, 2024

@msporny Without a proper Ed25519Signature2020 context, the proof is expanded with using of example context, e.g. https://www.w3.org/ns/credentials/examples#Ed25519Signature202 instead of https://w3id.org/security#Ed25519Signature2020. This PR fixes that.

I expect no issues for other implementations, on the contrary, without the right context, the result using example context is not verifiable, i.e. a proof type is unknown to a verifier.

@Wind4Greg
Copy link
Contributor

Thanks @filip26 and @msporny! Let me update my test vector code and see if I can confirm. Cheers Greg

Copy link
Contributor

@Wind4Greg Wind4Greg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified these against my vectors. Thanks @filip26!

Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks like what I asked for in #75. I haven't checked this against our implementation but it definitely looks better.

@msporny msporny merged commit debf4d2 into w3c:main Mar 3, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants