-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address VP Token interop #110
Comments
definitely want input on this |
Should we perhaps just say vp_token is not a valid VP? |
Below is the definition of the VP Token from OID4VP. I think it's pretty clear VP Token != W3C VP?
For W3C VCDM, we probably need to update this Credential Format Profile section in OID4VP |
@Sakurann is there a specific typ value for vp_token? Would you be willing to add a PR to address this issue? |
VP Token is not a JWT in itself (it's a VP itself it or an array of VPs) so no 'typ'. Do you mean PR in this repo or in OID4VP? (Guess I can do both) |
@Sakurann --
-- seems to disagree with this, also from you --
Perhaps you could adjust one or the other (or both), to clarify? |
If so we can't use I think clarifying text should be added in both places, ideally this repo just points to the text in the OIDF spec, and lets it provide the clarity, since it defined |
Just chiming in that I welcome such clarification in both places as well. When I read the OpenID4VC specs initially, I had no idea that |
here is definition of VP Token fromt the spec:
what guidance would be useful on top of this..? |
I marked this as post-CR because normative changes to the spec are not being proposed. These clarifications would be nice-to-have, if someone wants to create PRs. |
Should this now include the envelope credentials property? |
@OR13 what concretely would you like us to do for this issue at present, having passed the one-year anniversary of the issue? |
It's solved for, we support VPs using enveloped credentials, and the VP data model from the core spec. This issue can be closed |
Closing, per Orie's comment. |
https://openid.net/specs/openid-4-verifiable-presentations-1_0.html
We need spec text addressing "VP Token" vs "vp+ld+jwt".
cc @Sakurann @selfissued @tplooker
The text was updated successfully, but these errors were encountered: