Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Techniques (issue 2482) #2490

Merged
merged 65 commits into from
Oct 21, 2022
Merged

update Techniques (issue 2482) #2490

merged 65 commits into from
Oct 21, 2022

Conversation

fstrr
Copy link
Contributor

@fstrr fstrr commented May 29, 2022 •
edited by pr-preview bot
Loading

update H28 for HTML and presentation fixes

  1. removed links to HTML 4.01 spec
  2. removed references to HTML 4 and XHTML and the acronym element.
  3. fixed horizontal scrolling on code samples.
  4. fixed defining an abbreviation so the code now defines an abbreviation.
  5. fixed links to resources.

update H2 for HTML

  1. removed references to HTML4 and XHTML.
  2. changed references to HTML5 to HTML.
  3. updated Resources link to HTML spec.

update H24 for HTML, typos, code fixes

  1. removed references to XHTML.
  2. fixed “imagemap” typo.
  3. updated area elements in code samples per current HTML spec.
  4. updated Resources links to current HTML spec.

update H25 for HTML and typos

  1. remove references to XHTML.
  2. add doctype and lang attribute to code sample.
  3. update Resources links to link to the current HTML spec.
  4. changed reference to frameset to frames.

update ARIA 1 for HTML and clarity

  1. remove references to XHTML.
  2. update links to updated URLs and non-obsolete documents
  3. removed Examples 1 and 6 as they were the same as Example 3 (descriptions on buttons).
  4. Removed Example 5 as it was the same as Example 3 but specifically for an XHTML form.
  5. added autocomplete attribute to Example 2.

update ARIA 2 for HTML and clarity

  1. remove references to XHTML.
  2. remove Examples 4 (XHTML specific) and 5 (same basic example as Example 1).
  3. Updated Example 1 to put the * next to the label, which is what the description said it did, but it didn’t.
  4. Updated Example 1 to put the (required) next to the label, which is what the description said it did, but it didn’t.
  5. Added text to the empty h3 elements in multiple examples.
  6. added autocomplete attributes to Examples 1 and 2.
  7. Updated Example 2 to put the (required) next to the label, which is what the description said it did, but it didn’t.
  8. Example 3:
    1. fixed the code so that the title says “after” to match the CSS
    2. added required aria-checked attributes to radio elements
    3. fixed horizontal scrolling.
    4. changed :after to ::after

update for SCR2 HTML and code samples

  1. remove code example comments referencing JavaScript 1.4, Netscape 6, IE5 (!)
  2. fixed horizontal scrolling.
  3. marked up code as code.
  4. removed reference to XHTML.

update SCR16 for HTML

  1. updated code example: changed doctype to html
  2. marked up code as code.

update H37 and H39 update H37

  1. Replace HTML 4.01 links to links in the current HTML spec.

Preview | Diff

fstrr added 12 commits May 24, 2022 20:08
@fstrr
update H28 for HTML and presentation fixes
7cadec1 
1. removed links to HTML 4.01 spec
2. removed references to HTML 4 and XHTML and the `acronym` element.
3. fixed horizontal scrolling on code samples.
4. fixed defining an abbreviation so the code now defines an abbreviation.
5. fixed links to resources.
@fstrr
update H2 for HTML
7590970 
1. removed references to HTML4 and XHTML.
2. changed references to HTML5 to HTML.
2. updated Resources link to HTML spec.
@fstrr
update H24 for HTML, typos, code fixes
1217e80 
1. removed references to XHTML.
2. fixed “imagemap” typo.
3. updated `area` elements in code samples per current HTML spec.
4. updated Resources links to current HTML spec.
@fstrr
update H25 for HTML and typos
953f10d 
1. remove references to XHTML.
2. add doctype and lang attribute to code sample.
3. update Resources links to link to the current HTML spec.
4. changed reference to `frameset` to `frames`.
@fstrr
Update ARIA 1 for HTML and clarity
5e9cd09 
1. remove references to XHTML.
2. update links to updated URLs and non-obsolete documents
3. removed Examples 1 and 6 as they were the same as Example 3 (descriptions on buttons).
4. Removed Example 5 as it was the same as Example 3 but specifically for an XHTML form.
4. added autocomplete attribute to Example 2.
@fstrr
Update ARIA2 for HTML, clarity
aa3f306 
1. remove references to XHTML.
2. remove Examples 4 (XHTML specific) and 5 (same basic example as Example 1).
3. Updated Example 1 to put the * next to the label, which is what the description said it did, but it didn’t.
4. Updated Example 1 to put the (required) next to the label, which is what the description said it did, but it didn’t.
5. Added text to the empty `h3` elements in multiple examples.
6. added autocomplete attributes to Examples 1 and 2.
7. Updated Example 2 to put the (required) next to the label, which is what the description said it did, but it didn’t.
8. Example 3:
    1. fixed the code so that the title says “after” to match the CSS.
    2. added required aria-checked attributes to radio elements
    3. fixed horizontal scrolling.
    4. changed `:after` to `::after`
@fstrr
Update for HTML and code samples
1691615 
1. remove code example comments referencing JavaScript 1.4, Netscape 6, IE5 (!)
2. fixed horizontal scrolling.
3. marked up code as `code`.
4. removed reference to XHTML.
@fstrr
Update SCR16 for HTML
f9b8b2c 
1. updated code example: changed doctype to html
2. marked up code as `code`.
@fstrr
update H37 for replace HTML 4.01 links
db561cd
@fstrr
update H39 to replace references to HTML 4.01
2469ef3
@fstrr
delete h73
7c3496e 
the `summary` attribute is obsolete in html, so this technique isn’t relevant.
@fstrr
delete H45 as longdesc is obsolete in HTML
085d76d
@fstrr fstrr requested a review from alastc May 29, 2022 21:54
@fstrr
update H49 for HTML, clarity
0fc3d90 
Technique:
1. removed references to HTML 4.01.
2. updated HTML links to current spec.
3. after checking support, removed content about browsers not currently supporting the `q` element, and related example code and how to fix the element in Internet Explorer.
4. fixed horizontal scrolling of code example.
5. added headings to code example as per other pages.

Working example:
1. changed the `doctype` to HTML.
2. added `lang` attribute.
3. updated charset
4. edited headings to match H49.
@alastc
Copy link
Contributor

alastc commented May 30, 2022

@fstrr - I'm just trying to work out if you made a lot of changes in the <head>, or is the github diff just making it look like that?

@patrickhlauke
Copy link
Member

@alastc looks like line breaks have been inserted where before things were munged into a single line

fstrr added 6 commits May 31, 2022 10:22
@fstrr
update H97 for HTML and clarity
9a98da4 
1. fixed typos.
2. improved code examples:
    1. fixed horizonal scrolling.
    2. removed reference to a `generic` nav element.
    3. added seperate lines of links instead of one list item with the text “a list of links here” inside it.
@fstrr
update H59 for HTML and clarity
017fd48 
1. remove references to `start`, `contents`, and `index` types as they’re no longer in the HTML spec.
2. update Resources links to link to current HTML spec and remove links to stale content.
@fstrr
Update H64 for HTML and accuracy
e88229f 
1. removed references to framesets.
2 updated code example to remove fallback content for browsers that don’t support iframes.
3. Updated code example:
    1. changed doctype to HTML
    2. added lang attribute to html element
    3. removed fallback content
4. update Resources links to remove HTML 4.01 and stale content.
5. update TOC page to remove reference to frames.
@fstrr
Update H98 for HTML
3c9d5f7 
1. remove references to HTML 5.2—leave unversioned.
2. mark up code as code.
3. better highlight code in code example.
4 update TOC.
@fstrr
Update for HTML, typos, clarity
cadb0fc 
1. Remove references to HTML 5.2—leave unversioned.
2. Fix badly implemented resource links.
3. Update example to better highlight incorrect code.
4. Mark up code as code.
@fstrr
Delete H4
8a15893 
It’s not referenced from any Understanding documents and is bad practice for manipulating focus order.
@fstrr
Copy link
Contributor Author

fstrr commented Jun 1, 2022

@alastc The only changes in head were adding line breaks and changing the CSS link from href="../../css/sources.css" to href="../../css/editors.css".

fstrr added 4 commits June 1, 2022 08:34
@fstrr
Update H32 for HTML, code example, links
2974638 
1. updated Resources links to remove 404 and add HTML spec.
2. Example 1:
    1. Added content to the empty `h3` element.
    2. Added `autocomplete` attribute to email `input`.
    3. Removed `<br>` elements.
3. Removed example 2 as it was the same as Example 1 apart from a different value for the `action` attribute.
4. Marked up abbreviations as abbreviations.
5. Marked up code as code.
@fstrr
Update H40 for HTML code examples
095c115 
1. removed mention of HTML5.
2. updated code example:
    1. swapped `em` for `i` as that’s a more-suitable element.
    2. removed `p` elements from `dd`
3. Updated resources links to replace HTML 4.01 links to current HTML spec.
@fstrr
Update H42 for HTML, code, resources
de4b7d7 
1. Updated Example 2:
    1. replaced `div`s with structural semantic elements
    2. replaced `class=leftnav` with for `class=“side-bar” for the right-hand section.
2. Updated Resources links:
    1. replaced HTML 4.01 with HTML
    2. Found more up-to-date tutorials that don’t reference the old HTML font size attributes.
3. remove reference to XHTML.
@fstrr
Delete H35 - applet element is obsolete
4cbeb3e 
Delete H35 and documents that reference it.
@fstrr
Copy link
Contributor Author

fstrr commented Jun 1, 2022 •
edited
Loading

update H97 for HTML and clarity

  1. fixed typos.
  2. improved code examples:
    1. fixed horizontal scrolling.
    2. removed reference to a "generic" nav element.
    3. added separate lines of links instead of one list item with the text “a list of links here” inside it.

update H97 for HTML and clarity

  1. remove references to start, contents, and index types as they’re no longer in the HTML spec.
  2. update Resources links to link to current HTML spec and remove links to stale content.

update H64 for HTML and accuracy

  1. removed references to framesets.
  2. updated code example to remove fallback content for browsers that don’t support iframes.
  3. updated code example:
    1. changed doctype to HTML
    2. added lang attribute to html element
    3. removed fallback content
  4. update Resources links to remove HTML 4.01 and stale content.
  5. update TOC page to remove reference to frames.

update H98

  1. remove references to HTML 5.2—leave un-versioned.
  2. mark up code as code.
  3. better highlight code in code example.
  4. update TOC.

Update F107 for HTML, typos, clarity

  1. Remove references to HTML 5.2—leave un-versioned.
  2. Fix badly implemented resource links.
  3. Update example to better highlight incorrect code.
  4. Mark up code as code.

Delete H4 (creating a logical tab order through links, form controls, and objects)

It’s not referenced from any Understanding documents and is bad practice for manipulating focus order. This also removes links from other WCAG documents.

update H32 for HTML, code example, links

  1. updated Resources links to remove 404 and add HTML spec.
  2. Example 1:
    1. Added content to the empty h3 element.
    2. Added autocomplete attribute to email input.
    3. Removed br elements.
  3. Removed example 2 as it was the same as Example 1 apart from a different value for the action attribute.
  4. Marked up abbreviations as abbreviations.
  5. Marked up code as code

update H40 for code

  1. removed mention of HTML5.
  2. updated code example:
    1. swapped em for i as that’s a more-suitable element.
    2. removed p elements from dd.
  3. Updated resources links to replace HTML 4.01 links to current HTML spec.

update H42 for HTML, code, resources

  1. Updated Example 2:
    1. replaced divs with structural semantic elements
    2. replaced class=leftnav with for class=“side-bar for the right-hand section.
  2. Updated Resources links:
    1. replaced HTML 4.01 with HTML
    2. Found more up-to-date tutorials that don’t reference the old HTML font size attributes.
  3. remove reference to XHTML.

delete H35 and references to it - applet element is obsolete.

  1. Delete H35. This also removes links from other WCAG documents.

update H58 for HTML, Resources, code example

  1. removed references to HTML 4.01, including links to that spec.
  2. added standard h3 element to code example.
  3. fixed “subcodes” typo.
  4. marked up code as code.

update H57 for code tags

  1. wrap code in code.

delete H60 and references to it

  1. glossary isn’t a valid value for the link rel= element in the HTML living standard.

update H43 for HTML, typos, resources

  1. remove references to HTML 4.01 and XHTML.
  2. tweak spacing in code example
  3. mark up code as code.
  4. fix typos
  5. update Resources link.

@alastc
Copy link
Contributor

alastc commented Jun 3, 2022

Note to self: Without longdesc, notify the group of this change before merging.

@alastc alastc added Inform Group Things to let group know about prior to merge. and removed Survey - Ready for labels Jul 15, 2022
@fstrr
Update H86 for content, examples, resources
7660ca2 
This Technique is really outdated and could possibly be considered for deletion. However, I’ve updated it, including re-titling it.
1. Removed references to XHTML.
2. Added content on emojis.
3. Re-written content to de-emphasize the popularity of emotions, ASCII art, and Leetspeak.
4. Fixed the skip link.
5. Added another ASCII art example with an ARIA solution.
6. Re-wrote the test procudure.
7. Added some resources.
8. Marked up code as `code`.
@fstrr
Copy link
Contributor Author

fstrr commented Jul 19, 2022 •
edited
Loading

Update H83 for HTML, note, resources

  1. Remove references to HTML 4.01, XHTML Transitional, HTML5.
  2. Made the note in the description a note.
  3. Update resources to link to HTML living spec.
  4. Mark up code as code.

Update H84 for HTML, code, examples, resources

  1. removed references to XHTML.
  2. Changed example 1 so it didn’t need truncating.
  3. Changed example 2 so the button wasn’t labelled “do it”.
  4. marked up code as code.
  5. Updated Resources:
    1. Removed 404ing link.
    2. Added links to HTML Living Spec.

Update H85 and TOC for HTML, examples, clarity, resources

  1. Removed references to XHTML.
  2. Clarified non-semantically grouping content.
  3. Updated Example 1:
    1. removed options with just an ellipsis.
  4. Updated Example 2:
    1. changed example to animals as the Techniques example was overly verbose.
  5. Updated Resources:
    1. replaced links to HTML 4.01 spec with HTML living spec.
    2. removed stale link.
    3. updated WebAIM link to https
  6. Marked up code as code.
  7. Lowercased all uppercased references to HTML elements.

Update H56 for HTML, example, resources

  1. Remove references to XHTML.
  2. Mark up code as code.
  3. Update references to replace HTML 4.01 with HTML living spec.
  4. Added a heading to the example.

Update H86 for content, examples, resources

This Technique is really outdated and could possibly be considered for deletion. However, I’ve updated it, including re-titling it. Raw Git version of H86 update.

  1. Removed references to XHTML.
  2. Added content on emojis.
  3. Re-written content to de-emphasize the popularity of emotions, ASCII art, and Leetspeak.
  4. Fixed the skip link.
  5. Added another ASCII art example with an ARIA solution.
  6. Re-wrote the test procedure.
  7. Added some resources.
  8. Marked up code as code.

@fstrr
Update H71 for examples
33fe91d 
1. Added some non-male authors to an example.
2. Added `autocomplete` attributes to an example.
@fstrr
Update H81 for HTML, examples, test procedure, resourses
84b69e9 
1. Removed references to XHTML.
2. Added `abbr` and `nav` elements to examples.
3. tweaked the test procedure to be clearer.
4. updated the expected results as only 2 and 3 need to be true.
5. added resources.
6. marked up code as `code`.
@fstrr
Update G134 for content, resources
e55d9ae 
1. Remove references to XHTML.
2. update links listed in issue 2544.
3. double-checked links in issue 657.
4. Updated links that now support https.
5. Corrected typo in Chris Pederick’s name.
6. Marked up headings as headings.
7. Removed a couple of links to tools that haven’t been updated in many years.
@fstrr
Copy link
Contributor Author

fstrr commented Jul 21, 2022

Update H71 for examples

This had been updated earlier, but I re-visited it.

  1. Added some non-male authors to an example.
  2. Added autocomplete attributes to an example.

Update H81 for HTML, examples, test procedure, resources

  1. Removed references to XHTML.
  2. Added abbr and nav elements to examples.
  3. tweaked the test procedure to be clearer.
  4. updated the expected results as only 2 and 3 need to be true.
  5. added resources.
  6. marked up code as code.

Update G134 for content and resources.

This closes #2544 and #657

  1. Remove references to XHTML.
  2. update links listed in issue 2544.
  3. double-checked links in issue 657.
  4. Updated links that now support https.
  5. Corrected typo in Chris Pederick’s name.
  6. Marked up headings as headings.
  7. Removed a couple of links to tools that haven’t been updated in many years.

@fstrr fstrr mentioned this pull request Jul 22, 2022
Open
@fstrr
Update H34 for code, resources
e89f4b2 
1. Remove references to XHTML.
2. Mark up code as `code`.
3. Update resource document name that had changed.
@fstrr
Updated H44 for content, code, examples, resources
9fdbbee 
1. Removed references to XHTML.
2. Added all current input types from the HTML living spec.
3. Added links to existing references to criteria
4. Updated Example 3 to include a `fieldset` and `legend` and removed the note saying it should be considered.
5. Updated Resources to add links to HTML living spec.
6. Marked up code as `code`.
@fstrr
Copy link
Contributor Author

fstrr commented Aug 2, 2022

Update H34 for code, resources

  1. Remove references to XHTML.
  2. Mark up code as code.
  3. Update resource document name that had changed.

Updated H44 for content, code, examples, resources

  1. Removed references to XHTML.
  2. Added all current input types from the HTML living spec.
  3. Added links to existing references to criteria
  4. Updated Example 3 to include a fieldset and legend and removed the note saying it should be considered.
  5. Updated Resources to add links to HTML living spec.
  6. Marked up code as code.

@alastc alastc mentioned this pull request Aug 30, 2022
Open
@bruce-usab bruce-usab self-assigned this Sep 23, 2022
bruce-usab
bruce-usab approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@bruce-usab bruce-usab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, what a labor of love this must have been!

@awkawk
Copy link
Member

awkawk commented Sep 28, 2022

I have a doubt about H98 and F107 as the WCAG 2.1 Spec normatively refers to the HTML 5.2 autocomplete list. Perhaps those shouldn't change?

@fstrr
Copy link
Contributor Author

fstrr commented Sep 30, 2022

@awkawk Thanks for catching that. I've replaced the references to HTML 5.2

@alastc alastc merged commit 661c32a into main Oct 21, 2022
@fstrr fstrr deleted the issue-2482 branch January 10, 2023 16:18
@giacomo-petri giacomo-petri mentioned this pull request Apr 9, 2024
Closed
giacomo-petri added a commit that referenced this pull request Apr 9, 2024
@giacomo-petri
Removed H35 from 1.1.1 understanding doc
fe8eadf 
H35 technique was removed with #2490
@giacomo-petri giacomo-petri mentioned this pull request Apr 9, 2024
Merged
mbgower added a commit that referenced this pull request Apr 30, 2024
@giacomo-petri @mbgower
Removed H35 from 1.1.1 understanding doc (#3779)
786828f 
Closes: #3619 

Technique H35 has been removed with #2490, but link was still available
in 1.1.1 Non-text Content Understanding doc.
Removed H35 link from Understanding doc.

Co-authored-by: Mike Gower <mikegower@gmail.com>
kfranqueiro added a commit to kfranqueiro/wcag that referenced this pull request Jul 12, 2024
@kfranqueiro
Restore techniques removed in w3c#2490, with obsolete front-matter
fee529a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryjom maryjom maryjom left review comments

@bruce-usab bruce-usab bruce-usab approved these changes

@alastc alastc Awaiting requested review from alastc

Assignees

@bruce-usab bruce-usab

Labels
Editorial Inform Group Things to let group know about prior to merge. WCAG 2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@fstrr @alastc @patrickhlauke @michael-n-cooper @awkawk @maryjom @bruce-usab