-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial suggestions for consistent links to definitions and capitalization #3038
Open
maryjom
wants to merge
66
commits into
main
Choose a base branch
from
mjm-wcag-editorial-suggestions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be consistent with the rest of the document uses.
To be consistent with the rest of the document
For consistency with rest of document.
To be consistent in it's use, art shouldn't be capitalized.
In 2 places "block of text" is used. If we add this option, then new SC can link to the definition.
This is so uses of plural can link to this definition.
"Paused" definition is used in other instances of the word "pause" where it means the same thing, so this shouldn't cause any problems.
patrickhlauke
approved these changes
Feb 20, 2023
maryjom
changed the title
Editorial suggestions for consistent links of definitions and capitalization
Editorial suggestions for consistent links to definitions and capitalization
Feb 20, 2023
# Conflicts: # guidelines/sc/21/text-spacing.html # guidelines/sc/22/accessible-authentication-enhanced.html # guidelines/sc/22/focus-appearance.html # guidelines/sc/22/target-size-minimum.html # guidelines/terms/20/assistive-technology.html # guidelines/terms/20/blocks-of-text.html # guidelines/terms/20/input-error.html # guidelines/terms/20/mechanism.html # guidelines/terms/21/single-pointer.html # guidelines/terms/22/focus-indicator.html
Those merge conflicts weren't fun. |
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kfranqueiro
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed a couple of leftover unresolved terms, and restored one change that probably got lost in the merge conflicts Francis mentioned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff