Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't force term names to lowercase in definition lists #3978

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

kfranqueiro
Copy link
Contributor

@kfranqueiro kfranqueiro commented Jul 19, 2024

This fixes a couple of issues in the build system that I noticed while reviewing #3038:

I also noticed that the term "cognitive function test" includes a capital C, but doesn't seem to warrant one (typically the only term capitalization is for acronyms or proper nouns). (EDIT: removed this part, as Kevin pointed out it is addressed in another issue + open PR)


Preview | Diff

@w3cbot
Copy link

w3cbot commented Jul 19, 2024

kfranqueiro marked as non substantive for IPR from ash-nazg.

Copy link

netlify bot commented Jul 19, 2024

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit e983085
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/669e7454216c310008197981
😎 Deploy Preview https://deploy-preview-3978--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@iadawn iadawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove change in case for 'cognitive function test'. This is raised and addressed via #3942

Otherwise, fine.

@kfranqueiro
Copy link
Contributor Author

Remove change in case for 'cognitive function test'. This is raised and addressed via #3942

Done, thanks for spotting that!

@kfranqueiro kfranqueiro merged commit e1f139f into main Jul 22, 2024
5 checks passed
@kfranqueiro kfranqueiro deleted the kgf-non-lowercase-terms branch July 22, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants