Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links with different names pointing to equal resources in Related Resources in Understanding SC 3.3.8: Accessible Authentication (Minimum) #3597

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

giacomo-petri
Copy link
Contributor

Closes: #3596

- Removed redundant unnecessary link in related resouces
- Removed full stops from the list items
@mbgower
Copy link
Contributor

mbgower commented Dec 7, 2023

I removed the PR from the Project, since we have the issue already in the list.

<li><a href="https://webauthn.io/">WebAuthN Demo site</a>.</li>
<li><a href="https://en.wikipedia.org/wiki/OAuth">OAuth on Wikipedia</a>.</li>
<li><a href="https://www.w3.org/TR/webauthn/">WebAuthN specification</a></li>
<li><a href="https://developer.mozilla.org/en-US/docs/Web/API/Web_Authentication_API">Web Authentication API on MDN</a></li>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will produce this list of links:

  • WebAuthN specification
  • Web Authentication API on MDN
  • WebAuthN Demo site
     

I think that we should be grouping the WebAuthN links like:

  • WebAuthN specification
  • WebAuthN Demo site
  • Web Authentication API on MDN
     

I don't understand the function of this, just seeing an odd ordering.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mgifford. @giacomo-petri does this suggested order work for you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it works. I believe the intention was to present a list of references without a specific order. However, it would be even more beneficial if we could rearrange them to enhance the coherence of the reading sequence.
Additionally, I've addressed another typo in these links.

Copy link
Contributor

@mbgower mbgower Jan 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giacomo-petri I'm just glancing through changes before tomorrow's meeting. The order appears to be the same still? Assuming you will reorder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it. Not sure what happened. Adjusting right now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In "Files changes" I see the proper order. Are you seeing something different?

@mbgower mbgower merged commit 0625fbf into main Jan 18, 2024
1 check passed
@mbgower mbgower deleted the giacomo-petri-accessible-authentication-minimum-patch-2 branch January 18, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants